feat(dashboard): run query for chart only if visible #21488
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktmud
reviewed
Sep 15, 2022
| </div> | ||
| {isLoading && !isDeactivatedViz && <Loading />} | ||
| </Styles> | ||
| <InView triggerOnce onChange={this.handleChartInView}> |
There was a problem hiding this comment.
Can we add a rootMargin to page bottom so charts near the bottom but below the fold can load faster (so users can see less loading states)?
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Since the current Dashboard requests entire apis for runQuery all together, it easily exceeds the maximum parallel HTTP connections.
This commit introduces the
react-intersection-observerto minimize the runQuery for charts.It will only request the runQuery only if the current Chart is within the visible viewport. (As scroll down to the bottom chart, it will gradually request the remaining runQuery.)
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
before--inview.mov
after--inview.mov
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION