Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WiP] chore: deprecate /superset/annotation_json/<int:layer_id> #22119

Conversation

dpgaspar
Copy link
Member

@dpgaspar dpgaspar commented Nov 14, 2022

SUMMARY

Continuing the effort on deprecating all /superset/ REST API endpoints
Deprecates /superset/annotation_json/<int:layer_id>

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@dpgaspar dpgaspar changed the title chore: deprecate /superset/annotation_json/<int:layer_id> [WiP] chore: deprecate /superset/annotation_json/<int:layer_id> Nov 14, 2022
@codecov
Copy link

codecov bot commented Nov 14, 2022

Codecov Report

Merging #22119 (ad3d800) into master (824dc71) will increase coverage by 11.25%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           master   #22119       +/-   ##
===========================================
+ Coverage   55.84%   67.10%   +11.25%     
===========================================
  Files        1831     1831               
  Lines       70002    70003        +1     
  Branches     7570     7570               
===========================================
+ Hits        39094    46976     +7882     
+ Misses      28950    21069     -7881     
  Partials     1958     1958               
Flag Coverage Δ
hive 52.88% <100.00%> (+<0.01%) ⬆️
mysql 78.41% <100.00%> (?)
postgres 78.47% <100.00%> (?)
presto 52.78% <100.00%> (+<0.01%) ⬆️
python 81.59% <100.00%> (+23.49%) ⬆️
sqlite 76.94% <100.00%> (?)
unit 51.26% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/views/core.py 76.11% <100.00%> (+40.59%) ⬆️
superset/config.py 91.84% <0.00%> (+0.62%) ⬆️
superset/views/database/views.py 31.36% <0.00%> (+0.90%) ⬆️
superset/sql_parse.py 96.49% <0.00%> (+1.16%) ⬆️
superset/db_engine_specs/__init__.py 85.71% <0.00%> (+1.19%) ⬆️
superset/tables/models.py 67.53% <0.00%> (+1.29%) ⬆️
superset/exceptions.py 91.30% <0.00%> (+1.73%) ⬆️
superset/reports/models.py 100.00% <0.00%> (+2.00%) ⬆️
superset/explore/utils.py 100.00% <0.00%> (+2.27%) ⬆️
superset/datasets/commands/importers/v1/utils.py 58.33% <0.00%> (+2.38%) ⬆️
... and 284 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@EugeneTorap
Copy link
Contributor

Superseded by #22496
@dpgaspar close?

@dpgaspar dpgaspar closed this Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants