chore(connector): Deprecate connectors.base #22594
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
john-bodley
force-pushed
the
john-bodley--deprecate-connectors-base
branch
from
9b78ac2
to
00916e3
Compare
john-bodley
commented
Jan 5, 2023
| @@ -27,9 +27,6 @@ | |||
| from superset.models.slice import Slice | |||
| from superset.utils.core import get_user_id | |||
|
|
|||
| if TYPE_CHECKING: | |||
| from superset.connectors.base.models import BaseDatasource | |||
There was a problem hiding this comment.
This was never used. I'm surprised Pylint didn't recognize it, but maybe it's not well versed with the TYPE_CHECKING construct and thus it felt it was used.
john-bodley
force-pushed
the
john-bodley--deprecate-connectors-base
branch
2 times, most recently
from
4680ca2
to
83e6043
Compare
john-bodley
force-pushed
the
john-bodley--deprecate-connectors-base
branch
from
83e6043
to
b58ceab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
I was running into CI issues in #22413 which I suspect maybe related to the fact that the base datasources/columns/metrics which might not adhere to the SQLAlchemy relationship model, i.e.,
BaseDatasource.columns/BaseDatasource.metricsare defined as Python lists as opposed to aSQLAlchemy.orm.relationship.Somewhat of a Yak Shaving experience, this PR simply deprecates the abstract classes—
BaseDatasource,BaseColumn, andBaseMetric—which are no longer needed given that we no longer support the native Druid connector. Note this refactor effort is far from complete—there remains endless spaghetti code which uses a datasource type mapping—but hopefully it's a step (albeit small) in the right direction.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION