Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add pandas performance dependencies #24768

Merged
merged 1 commit into from
Jul 21, 2023

Conversation

sebastianliebscher
Copy link
Contributor

SUMMARY

This is a follow-up of #24705 that bumped pandas.

Pandas 2.0 introduced installing optional performance dependencies via pip extras. This PR adds these dependencies which are recommended.

You are highly encouraged to install these libraries, as they provide speed improvements, especially when working with large data sets.

  • added [performance] extra to setup.py
  • pip-install-multi --no-upgrade to freeze packages

TESTING INSTRUCTIONS

  • pytest ./tests/unit_tests/
  • scripts/tests/run.sh --module tests/integration_tests/

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jul 21, 2023

Codecov Report

Merging #24768 (4fd9d64) into master (341b8d4) will increase coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 4fd9d64 differs from pull request most recent head 46dc7fd. Consider uploading reports for the commit 46dc7fd to get more accurate results

@@           Coverage Diff           @@
##           master   #24768   +/-   ##
=======================================
  Coverage   68.94%   68.94%           
=======================================
  Files        1902     1902           
  Lines       73902    73898    -4     
  Branches     8175     8174    -1     
=======================================
  Hits        50952    50952           
+ Misses      20837    20833    -4     
  Partials     2113     2113           
Flag Coverage Δ
hive 54.16% <ø> (ø)
mysql 79.20% <ø> (ø)
postgres 79.30% <ø> (ø)
presto 54.06% <ø> (ø)
python 83.33% <ø> (ø)
sqlite 77.87% <ø> (ø)
unit 54.94% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rts/src/MixedTimeseries/EchartsMixedTimeseries.tsx 0.00% <ø> (ø)
...hart-echarts/src/MixedTimeseries/transformProps.ts 0.79% <ø> (+<0.01%) ⬆️
.../plugin-chart-echarts/src/MixedTimeseries/types.ts 100.00% <ø> (ø)
...chart-echarts/src/Timeseries/EchartsTimeseries.tsx 0.00% <ø> (ø)
...gin-chart-echarts/src/Timeseries/transformProps.ts 59.20% <ø> (+1.38%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@john-bodley john-bodley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@rusackas rusackas merged commit e060042 into apache:master Jul 21, 2023
27 checks passed
@sebastianliebscher sebastianliebscher deleted the pandas_perf branch July 21, 2023 23:40
@michael-s-molina michael-s-molina added v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch and removed v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch labels Jul 24, 2023
@eschutho
Copy link
Member

Just a heads up that there's a regression with Pandas 2.x with certain date time formats, and it is fixed in this PR: #24952

@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.1.0 labels Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 3.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants