fix: Ignores ResizeObserver errors in development mode #24868
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
webpack-dev-server
4.12.0 added a new feature to show runtime errors in the error overlay by default which resulted inResizeObserver
errors when running Superset in development mode.We only have one use of
ResizeObserver
in our codebase and it's not the root cause for the error, so it must be coming from a third party dependency. Given that this type of error is benign, we even have discussions to downgrade it to a warning, this PR changes the Webpack configuration to ignore related error messages.TESTING INSTRUCTIONS
Make sure the referenced error does not happen when running the application in development mode.
ADDITIONAL INFORMATION