Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update UPDATING.md regarding potential breaking change to ab_user.email column #25115

Conversation

john-bodley
Copy link
Member

SUMMARY

#25053 extended the ab_user.email column (which has a uniqueness key constraint associated with it) from 64 to 320 characters. This change could be problematic for some MySQL databases and thus this PR updates the UPDATING.md to include a line item about how the database needs to be reconfigured if this is indeed problematic.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

CI.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@john-bodley john-bodley added the v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch label Aug 29, 2023
@@ -106,7 +106,7 @@ Superset supports the following database engines/versions:
| Database Engine | Supported Versions |
| --------------------------------------------------------- | ---------------------------------- |
| [PostgreSQL](https://www.postgresql.org/) | 10.X, 11.X, 12.X, 13.X, 14.X, 15.X |
| [MySQL](https://www.mysql.com/) | 5.X |
| [MySQL](https://www.mysql.com/) | 5.7, 8.X |
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seemed prudent to list the supported versions of MySQL, i.e., those which are the currently supported.

@john-bodley john-bodley force-pushed the john-bodley--docs-bump-supported-mysql-versions branch from a3a5a6e to 0ed7904 Compare August 29, 2023 20:54
UPDATING.md Outdated Show resolved Hide resolved
Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the update @john-bodley!

@michael-s-molina michael-s-molina merged commit e642361 into apache:master Aug 30, 2023
28 checks passed
michael-s-molina added a commit that referenced this pull request Aug 30, 2023
…ser.email` column (#25115)

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
darwinsubramaniam pushed a commit to darwinsubramaniam/superset that referenced this pull request Sep 7, 2023
…ser.email` column (apache#25115)

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
…ser.email` column (apache#25115)

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
@mistercrunch mistercrunch added 🍒 3.0.0 🍒 3.0.1 🍒 3.0.2 🍒 3.0.3 🍒 3.0.4 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.1.0 labels Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch 🍒 3.0.0 🍒 3.0.1 🍒 3.0.2 🍒 3.0.3 🍒 3.0.4 🚢 3.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants