fix: Partially reverts #25007 #25124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
|
/testenv up |
|
@michael-s-molina Ephemeral environment spinning up at http://35.86.164.128:8080. Credentials are |
|
@sadpandajoe Could you help test the PR? |
john-bodley
approved these changes
Aug 30, 2023
|
Ephemeral environment shutdown and build artifacts deleted. |
darwinsubramaniam
pushed a commit
to darwinsubramaniam/superset
that referenced
this pull request
Sep 7, 2023
cccs-rc
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Mar 6, 2024
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR partially reverts #25007 and reintroduces a simplified version of
SavedQueryViewApithat is used by the application and was removed in the original PR.Fixes #25117. Hat tip to @sadpandajoe for discovering and creating the issue.
TESTING INSTRUCTIONS
Check #25117 for instructions.
ADDITIONAL INFORMATION