Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: generic marshmallow error component #25303

Merged
merged 6 commits into from
Oct 3, 2023

Add test

ce38fd5
Select commit
Loading
Failed to load commit list.
Merged

feat: generic marshmallow error component #25303

Add test
ce38fd5
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 3, 2023 in 1s

69.10% (+0.01%) compared to 36ed617

View this Pull Request on Codecov

69.10% (+0.01%) compared to 36ed617

Details

Codecov Report

Merging #25303 (ce38fd5) into master (36ed617) will increase coverage by 0.01%.
Report is 6 commits behind head on master.
The diff coverage is 92.50%.

@@            Coverage Diff             @@
##           master   #25303      +/-   ##
==========================================
+ Coverage   69.08%   69.10%   +0.01%     
==========================================
  Files        1909     1911       +2     
  Lines       74907    74938      +31     
  Branches     8297     8299       +2     
==========================================
+ Hits        51752    51783      +31     
- Misses      21013    21014       +1     
+ Partials     2142     2141       -1     
Files Coverage Δ
...omponents/ErrorMessage/MarshmallowErrorMessage.tsx 100.00% <100.00%> (ø)
...rset-frontend/src/components/ErrorMessage/types.ts 100.00% <100.00%> (ø)
...-frontend/src/components/FilterableTable/index.tsx 77.04% <100.00%> (+1.45%) ⬆️
superset-frontend/src/hooks/useJsonTreeTheme.ts 100.00% <100.00%> (ø)
superset/datasets/api.py 89.00% <ø> (+0.30%) ⬆️
superset/datasets/schemas.py 96.80% <100.00%> (+0.05%) ⬆️
superset/errors.py 94.59% <100.00%> (+0.07%) ⬆️
superset/exceptions.py 92.06% <100.00%> (+0.32%) ⬆️
superset-frontend/src/setup/setupErrorMessages.ts 0.00% <0.00%> (ø)
...tend/src/components/Datasource/DatasourceModal.tsx 69.64% <0.00%> (-5.36%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more