fix: Tags Page Polish #25403
Merged
fix: Tags Page Polish #25403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
@hughhhh can you add some screenshots, so people outside of Preset can know what changes this PR is introducing?
superset-frontend/src/features/allEntities/AllEntitiesTable.tsx
Outdated
Show resolved
Hide resolved
superset-frontend/src/features/allEntities/AllEntitiesTable.tsx
Outdated
Show resolved
Hide resolved
|
@hughhhh Thanks for updates. Could you add the screenshot for the update in the description? |
hughhhh
force-pushed
the
tags-polish-1
branch
from
91ecea2
to
14c97a1
Compare
lilykuang
approved these changes
Sep 29, 2023
| (tag: Tag) => | ||
| tag.type === 'TagTypes.custom' || tag.type === 1, | ||
| )} | ||
| maxTags={3} |
There was a problem hiding this comment.
Can this number be a constant on top of the file?
superset-frontend/src/features/allEntities/AllEntitiesTable.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Lily Kuang <lily@preset.io>
cccs-rc
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Mar 6, 2024
Co-authored-by: Lily Kuang <lily@preset.io>
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Updating tags page with request from product. The following changes were made:
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
After
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION