Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Make host.docker.internal available on linux #25547

Merged

Conversation

sebastianliebscher
Copy link
Contributor

SUMMARY

#25346 introduced an nginx container which uses host.docker.internal. Unfortunately, this is not available on Linux. This can be solved with the use of extra-hosts in docker-compose.yml.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Fixes the following error:

superset_nginx         | 2023/10/06 07:02:12 [emerg] 1#1: host not found in upstream "host.docker.internal:8088" in /etc/nginx/nginx.conf:94
superset_nginx         | nginx: [emerg] host not found in upstream "host.docker.internal:8088" in /etc/nginx/nginx.conf:94

TESTING INSTRUCTIONS

  • docker-compose up and check the nginx container logs
  • ping host.docker.internal from nginx container

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@sebastianliebscher sebastianliebscher changed the title fix: make host.docker.internal available on linux fix: Make host.docker.internal available on linux Oct 6, 2023
@craig-rueda craig-rueda merged commit 1786070 into apache:master Oct 6, 2023
29 checks passed
@sebastianliebscher sebastianliebscher deleted the fix-host-docker-internal branch October 6, 2023 23:06
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.1.0 labels Mar 8, 2024
sfirke pushed a commit to sfirke/superset that referenced this pull request Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 3.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants