Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Remove more redundant code in utils/core #25986

Merged
merged 2 commits into from
Nov 15, 2023
Merged

chore: Remove more redundant code in utils/core #25986

merged 2 commits into from
Nov 15, 2023

Conversation

sebastianliebscher
Copy link
Contributor

SUMMARY

This is basically a follow-up of #25912 to remove more redundant code. The unused classes were hard to spot so that's why this is a separate PR.

TESTING INSTRUCTIONS

  • local unit / integration tests + GitHub CI

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@justinpark justinpark added the review:checkpoint Last PR reviewed during the daily review standup label Nov 15, 2023
john-bodley
john-bodley approved these changes Nov 15, 2023
View reviewed changes
Copy link
Member

@john-bodley john-bodley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@john-bodley john-bodley merged commit d20b60e into apache:master Nov 15, 2023
29 checks passed
@sebastianliebscher sebastianliebscher deleted the chore/remove_more_redundancy branch November 16, 2023 07:52
@john-bodley john-bodley removed the review:checkpoint Last PR reviewed during the daily review standup label Nov 30, 2023
josedev-union pushed a commit to Ortege-xyz/studio that referenced this pull request Jan 22, 2024
@sebastianliebscher @josedev-union
chore: Remove more redundant code in utils/core (apache#25986)
2499eb3
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@sebastianliebscher
chore: Remove more redundant code in utils/core (apache#25986)
bf79ce8
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.1.0 labels Mar 8, 2024
sfirke pushed a commit to sfirke/superset that referenced this pull request Mar 22, 2024
@sebastianliebscher @sfirke
chore: Remove more redundant code in utils/core (apache#25986)
5fdcf1b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@john-bodley john-bodley john-bodley approved these changes

@michael-s-molina michael-s-molina Awaiting requested review from michael-s-molina

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 3.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sebastianliebscher @john-bodley @mistercrunch @justinpark