Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve CSP add base uri restriction #26251

Merged
merged 1 commit into from
Dec 13, 2023

Conversation

dpgaspar
Copy link
Member

@dpgaspar dpgaspar commented Dec 12, 2023

SUMMARY

Improves our current default CSP policy by adding base-uri to self. base-uri directive restricts the URLs which can be used in a document's element.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@dpgaspar dpgaspar added the v3.1 Label added by the release manager to track PRs to be included in the 3.1 branch label Dec 12, 2023
@michael-s-molina michael-s-molina added the v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch label Dec 12, 2023
Copy link

codecov bot commented Dec 12, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8644b1a) 69.21% compared to head (45fab1b) 69.17%.
Report is 28 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #26251      +/-   ##
==========================================
- Coverage   69.21%   69.17%   -0.05%     
==========================================
  Files        1941     1942       +1     
  Lines       75910    75947      +37     
  Branches     8458     8458              
==========================================
- Hits        52541    52536       -5     
- Misses      21174    21216      +42     
  Partials     2195     2195              
Flag Coverage Δ
hive 53.67% <ø> (-0.01%) ⬇️
mysql 78.08% <ø> (-0.07%) ⬇️
postgres 78.18% <ø> (-0.09%) ⬇️
presto 53.62% <ø> (-0.01%) ⬇️
python 82.86% <ø> (-0.10%) ⬇️
sqlite 76.83% <ø> (-0.09%) ⬇️
unit 55.79% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@kgabryje kgabryje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nytai
Copy link
Member

nytai commented Dec 13, 2023

@rusackas do we have any front-end logging enabled by default? This might affect any telemetry we might have recently added

@dpgaspar dpgaspar merged commit 578a899 into apache:master Dec 13, 2023
36 checks passed
@dpgaspar dpgaspar deleted the fix/csp-base-uri branch December 13, 2023 11:45
@rusackas
Copy link
Member

@rusackas do we have any front-end logging enabled by default? This might affect any telemetry we might have recently added

I think we'll be OK with the telemetry. The PR is still open until I sort out the tests, but the only change to the CSP change there just pokes a couple holes in the img-src setting.

michael-s-molina pushed a commit that referenced this pull request Dec 15, 2023
michael-s-molina pushed a commit that referenced this pull request Dec 18, 2023
josedev-union pushed a commit to Ortege-xyz/studio that referenced this pull request Jan 22, 2024
@mistercrunch mistercrunch added 🍒 3.0.3 🍒 3.0.4 🍒 3.1.0 🍒 3.1.1 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels labels Mar 8, 2024
sfirke pushed a commit to sfirke/superset that referenced this pull request Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch v3.1 Label added by the release manager to track PRs to be included in the 3.1 branch 🍒 3.0.3 🍒 3.0.4 🍒 3.1.0 🍒 3.1.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants