fix(chart): Resolve incorrect column customization when switching metrics in table chart

[soniagtm]

SUMMARY

I have found that when attempting to swap the positions of metrics in the table chart with applied column configuration, the column configuration is switched to another column, which is related to the addition of #19841 for maintaining configurations when metrics are renamed. To address this issue, I have added a condition to first check if the column name is found in the old metrics. If it is found, it will avoid updating the column configuration. Reassignment will only occur if the new column name is not found among the existing ones to maintain configurations when metrics are renamed.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before: Currency prefix is switched to SUM(quantity_ordered)

Before.mov

After: Currency prefix is applied to SUM(sales) as expected

After.mov

TESTING INSTRUCTIONS

1. Create a table chart with dimensions and two or more metrics.
2. Apply number formatting to any of the metrics.
3. Attempt to swap the positions of the metrics.

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (29633e7) 69.14% compared to head (1c99138) 69.15%.
Report is 5 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #26393      +/-   ##
==========================================
+ Coverage   69.14%   69.15%   +0.01%     
==========================================
  Files        1946     1946              
  Lines       75989    75991       +2     
  Branches     8479     8479              
==========================================
+ Hits        52544    52553       +9     
+ Misses      21266    21257       -9     
- Partials     2179     2181       +2     

Flag	Coverage Δ
javascript	56.48% <100.00%> (+0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[john-bodley]

Thanks @soniagtm for the fix. Would you mind adding a unit test to ensure we don't regress in the future?

[soniagtm]

Hi, I've added test cases for switching metric columns and changing their names. I'm not sure if this is the correct way to do so. Please let me know if any corrections or further additions are needed.

Thank you in advance!

[john-bodley]

@justinpark would you mind reviewing this?

[justinpark]

LGTM. Thanks for adding test specs