Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(CI): increase node JS heap size #30340

Merged
merged 1 commit into from
Sep 20, 2024
Merged

fix(CI): increase node JS heap size #30340

merged 1 commit into from
Sep 20, 2024

Conversation

rusackas
Copy link
Member

SUMMARY

This is a bit of a shot in the dark, but I saw that some Jest tests were failing due to Javascript running out of heap memory (see screenshot).
My conjecture is that the Native Filter tests we're struggling with are the same issue we're running into here.

So... let's throw a dart at the problem. Apparently, the default size is 1.5GB, so let's go to 4! GPT thinks this'll work for both jest, and the chrome/chromium browser we use in E2E tests, so here goes nothing! Apparently the small GH action runners have 7GB ram, so this seems reasonable-ish.

Screenshot 2024-09-19 at 3 53 47 PM

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

If CI passes, we should be good.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@github-actions github-actions bot added dependencies:npm github_actions Pull requests that update GitHub Actions code labels Sep 19, 2024
@dosubot dosubot bot added the javascript Dependabot - Pull requests that update Javascript code label Sep 19, 2024
@villebro
Copy link
Member

No PR talking about dialing something up should go without a reference to Spinal Tap..

image

@rusackas
Copy link
Member Author

No PR talking about dialing something up should go without a reference to Spinal Tap..

image

LOL, I'm literally trying to get a tattoo of that knob. Awaiting response from two artists.

@villebro
Copy link
Member

LOL, I'm literally trying to get a tattoo of that knob. Awaiting response from two artists.

After that I feel you should be granted permission to self-approve any PR making these types of changes 🎛️

Copy link
Member

@mistercrunch mistercrunch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TO ELEVEN!

@rusackas
Copy link
Member Author

Hmmm... one of the OTHER tests is failing, but (thankfully) not the usual native filters tests. Maybe I only turned it up to like 9. Let's see what a couple more GB does...

@villebro
Copy link
Member

Hmmm... one of the OTHER tests is failing, but (thankfully) not the usual native filters tests. Maybe I only turned it up to like 9. Let's see what a couple more GB does...

That's one of the less frequently flaking tests, and is probably unaffected by extra memory

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's hope this makes the Cypress tests less flaky/quicker 👍

@rusackas rusackas merged commit d435166 into master Sep 20, 2024
35 of 36 checks passed
@rusackas rusackas deleted the bump-node-memory-heap branch September 20, 2024 17:50
@rusackas
Copy link
Member Author

I'm actually optimistic about the quicker part... this should use less swap, at least.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies:npm github_actions Pull requests that update GitHub Actions code javascript Dependabot - Pull requests that update Javascript code size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants