Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix when use "Time Series - Line Chart" and "Big Number with Trendline" on dashboard #5035

Closed
wants to merge 1 commit into from

Conversation

yamoe
Copy link

@yamoe yamoe commented May 18, 2018

when i use "Time Series - Line Chart" and "Big Number with Trendline" on dashboard.
just show a blank page in grid-container.

error message in web console log :

Dashboard.jsx:150 Uncaught TypeError: Cannot read property 'concat' of undefined
    at Dashboard.getFormDataExtra (Dashboard.jsx:150)
    at GridLayout.jsx:151
    at Array.map (<anonymous>)
    at GridLayout.render (GridLayout.jsx:134)
    at ReactCompositeComponent.js:793
    at measureLifeCyclePerf (ReactCompositeComponent.js:73)
    at ReactCompositeComponentWrapper._renderValidatedComponentWithoutOwnerOrContext (ReactCompositeComponent.js:792)
    at ReactCompositeComponentWrapper._renderValidatedComponent (ReactCompositeComponent.js:819)
    at ReactCompositeComponentWrapper.performInitialMount (ReactCompositeComponent.js:359)
    at ReactCompositeComponentWrapper.mountComponent (ReactCompositeComponent.js:255)

because of formDataExtra.extra_filters and formDataExtra.filters is "undefined"
at incubator-superset/superset/assets/src/dashboard/components/Dashboard.jsx (about 145 lines)

@mistercrunch
Copy link
Member

Which version is this? Does it happen on master ?

@yamoe
Copy link
Author

yamoe commented May 20, 2018

yes. it's happened master HEAD version.

@yamoe
Copy link
Author

yamoe commented May 25, 2018

this bug has disappeared and i close it.
thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants