Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Explore] [Adhoc Metrics/Filters] Force Ace editor to refresh when it is shown #5038

Merged

Conversation

gabe-lyons
Copy link
Contributor

acerefresh

AceEditor has an optimization where it won't refresh itself if its value is set while the editor is hidden. (ajaxorg/ace#2497) Since the editor is hidden when its tab isn't selected, the editor has a stale value when it is shown after changes were made in the Simple tab.

In this PR I force refresh the editor using its exposed resize method every time it is foregrounded

test plan:

  • visualized in gif above

reviewers:
@michellethomas @john-bodley @graceguo-supercat @mistercrunch

@gabe-lyons gabe-lyons force-pushed the gabe_forcing_ace_editor_to_refresh branch from fe6a7c4 to 1db80df Compare May 21, 2018 15:53
@gabe-lyons gabe-lyons force-pushed the gabe_forcing_ace_editor_to_refresh branch from 1db80df to 719c625 Compare May 21, 2018 16:09
@codecov-io
Copy link

Codecov Report

Merging #5038 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5038   +/-   ##
=======================================
  Coverage   77.34%   77.34%           
=======================================
  Files          44       44           
  Lines        8671     8671           
=======================================
  Hits         6707     6707           
  Misses       1964     1964

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f66dae...719c625. Read the comment docs.

@williaster
Copy link
Contributor

LGTM

@williaster williaster merged commit 0e1fb62 into apache:master May 21, 2018
michellethomas pushed a commit to michellethomas/panoramix that referenced this pull request May 21, 2018
michellethomas pushed a commit to michellethomas/panoramix that referenced this pull request May 24, 2018
timifasubaa pushed a commit to timifasubaa/incubator-superset that referenced this pull request May 31, 2018
wenchma pushed a commit to wenchma/incubator-superset that referenced this pull request Nov 16, 2018
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.26.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.26.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants