[WIP] Add new escape characters to OnPasteSelect #7634
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mistercrunch
reviewed
Jun 1, 2019
| @@ -96,7 +96,7 @@ OnPasteSelect.propTypes = { | |||
| isValidNewOption: PropTypes.func, | |||
| }; | |||
| OnPasteSelect.defaultProps = { | |||
| separator: ',', | |||
| separator: [',','\n','\t'], | |||
There was a problem hiding this comment.
Linter is complaining about missing spaces after ,
|
Still looking into why the linter is failing |
1AB9502
changed the title
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CATEGORY
Choose one
SUMMARY
Our internal users love pasting stuff info filters from CSVs or excel docs.
Currently onPasteSelect only parses comma separated values. I added new line and tabs (you never know) to the separator array
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TEST PLAN
In order to test the implementation I pasted the following values into the filter sections in the charts
regression test:
12345,45678,78906
new values tests
12345,
45678,
78906
12345
45678
78906
All values got parsed correctly
REVIEWERS