Skip to content

Commit

Permalink
More PR comments
Browse files Browse the repository at this point in the history
  • Loading branch information
guberti committed Aug 25, 2021
1 parent b77aeca commit 32882c4
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 5 deletions.
2 changes: 1 addition & 1 deletion apps/microtvm/reference-vm/arduino/Vagrantfile
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ Vagrant.configure("2") do |config|
config.vm.provision "shell", path: "provision_setup.sh", env: {"TVM_HOME": dirs_to_mount[0]}, privileged: false

# Enable USB Controller on VirtualBox
vm_name = "microtvm-#{Time.now.tv_sec}"
vm_name = "microtvm-arduino-#{Time.now.tv_sec}"
config.vm.provider "virtualbox" do |vb, overrides|
vb.name = vm_name
vb.cpus = num_cores
Expand Down
11 changes: 7 additions & 4 deletions apps/microtvm/reference-vm/base-box-tool.py
Original file line number Diff line number Diff line change
Expand Up @@ -475,7 +475,7 @@ def parse_args():

# "test" has special options for different platforms, and "build", "release" might
# in the future, so we'll add the platform argument to each one individually.
platform_help_str = "Electronics platform to use (e.g. Arduino, Zephyr)"
platform_help_str = "Platform to use (e.g. Arduino, Zephyr)"

# Options for build subcommand
parser_build = subparsers.add_parser("build", help="Build a base box.")
Expand Down Expand Up @@ -506,9 +506,9 @@ def parse_args():
"iSerial field from `lsusb -v` output."
),
)
platform_subparsers = parser_test.add_subparsers(help=platform_help_str)
parser_test_platform_subparsers = parser_test.add_subparsers(help=platform_help_str)
for platform in ALL_PLATFORMS:
platform_specific_parser = platform_subparsers.add_parser(platform)
platform_specific_parser = parser_test_platform_subparsers.add_parser(platform)
platform_specific_parser.set_defaults(platform=platform)
platform_specific_parser.add_argument(
"--microtvm-platform",
Expand All @@ -534,7 +534,10 @@ def parse_args():
parser_release.add_argument(
"--platform-version",
required=True,
help="Platform version to release, in the form 'x.y'.",
help=(
"For Zephyr, the platform version to release, in the form 'x.y'. "
"For Arduino, the version of arduino-cli that's being used."
),
)

return parser.parse_args()
Expand Down

0 comments on commit 32882c4

Please sign in to comment.