[TVMC] Add an end_to_end benchmarking argument when benchmarking. #10256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwfromm
requested review from
leandron,
comaniac,
junrushao,
tqchen,
jroesch,
areusch,
yzhliu,
merrymercy and
icemelon
as code owners
added 2 commits
February 15, 2022 09:33
tmoreau89
requested changes
Feb 15, 2022
| # Optionally measure e2e data transfers from the | ||
| # CPU to device memory overheads (e.g. PCIE | ||
| # overheads if the device is a discrete GPU). | ||
| times = module.benchmark(dev, number=number, repeat=repeat, end_to_end=end_to_end) |
There was a problem hiding this comment.
we should use session.cpu() instead of dev since we need to include copy overheads from CPU memory to e.g. GPU memory
There was a problem hiding this comment.
Thanks for noting that, I added an if that sets dev to cpu if end_to_end is on.
pfk-beta
pushed a commit
to pfk-beta/tvm
that referenced
this pull request
Apr 11, 2022
…ache#10256) * Add an end_to_end benchmarking argument to TVMC run. * Add command line test. * Fix comment syntax. * Set device to cpu if end_to_end is on. * Tickle CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an extension to PR #10226 by @tmoreau89. It makes end to end benchmarking an option to
tvmc.runand defaults it to False. This provides an easy way to measure memory copies without changing the default behavior of TVMC. Please take a look @leandron @tmoreau89.