Use /usr/bin/env bash in shebang for all scripts under tests
#10277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes scripts executable on system without /bin/bash (NixOS)
yelite
requested review from
comaniac,
junrushao,
tqchen,
jroesch,
areusch,
yzhliu,
merrymercy and
icemelon
as code owners
driazati
reviewed
Feb 16, 2022
tests/lint/check_asf_header.sh
Outdated
| @@ -1,4 +1,4 @@ | |||
| #!/bin/bash -e | |||
| #!/usr/bin/env -S bash -e | |||
There was a problem hiding this comment.
While you're cleaning these up could you move all the bash -e usages into a set -e after the apache header everywhere? That way we can have a consistent bash invocation across all scripts
Suggested change
| #!/usr/bin/env -S bash -e | |
| #!/usr/bin/env bash |
There was a problem hiding this comment.
Updated. Actually it won't build without this change. The coreutil in the CI docker image might be old and doesn't have the -S arg for env.
There was a problem hiding this comment.
Some scripts already have set -euxo pipefail so I didn't add set -e to them
driazati
approved these changes
Feb 16, 2022
pfk-beta
pushed a commit
to pfk-beta/tvm
that referenced
this pull request
Apr 11, 2022
…e#10277) * Use /usr/bin/env bash in shebang This makes scripts executable on system without /bin/bash (NixOS) * Use `set -e` in script instead of `bash -e` in shebang
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes scripts executable on system without /bin/bash (NixOS).
Although this is not perfectly portable (some system may have /bin/env rather than usr/bin/env), it's better than just using /bin/bash (https://en.wikipedia.org/wiki/Shebang_(Unix)#Program_location).