Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the building error in android_deploy #1262

Merged
merged 2 commits into from
Jun 12, 2018

Conversation

nishi-t
Copy link
Contributor

@nishi-t nishi-t commented Jun 12, 2018

Fix the following error while doing gradle build and the document url in README.

/Users/tatsuya/work/tvm/apps/android_deploy/app/src/main/jni/../../../../../../include/../src/runtime/thread_pool.cc:76:31: error: no member named 'to_string' in namespace 'std'
        err += "Task " + std::to_string(i) + " error: " + par_errors_[i] + '\n';

Please review. @tqchen @PariksheetPinjari909

@@ -69,14 +69,14 @@ class ParallelLauncher {
tvm::runtime::threading::Yield();
}
if (!has_error_.load()) return 0;
std::string err("");
std::stringstream err;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is intended to use string, due to security issues raised in SGX backend, please revert this change and add a comment about it

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

std::stringstream was banned by sgx backend and we need it here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reverted this change and add a comment. Then I changed APP_STL to avoid the building error. Please review again.

@tqchen tqchen merged commit aed5ecd into apache:master Jun 12, 2018
tqchen pushed a commit to tqchen/tvm that referenced this pull request Jul 6, 2018
* Fix a link in android_deploy/README.md and a error while building android_deploy.

* revert and change APP_STL in Application.mk
mnuyens pushed a commit to mnuyens/tvm that referenced this pull request Jul 10, 2018
* Fix a link in android_deploy/README.md and a error while building android_deploy.

* revert and change APP_STL in Application.mk
sergei-mironov pushed a commit to sergei-mironov/tvm that referenced this pull request Aug 8, 2018
* Fix a link in android_deploy/README.md and a error while building android_deploy.

* revert and change APP_STL in Application.mk
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants