-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MXNET] LRN support in MXNET frontend #1520
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With minor change LGTM.
nnvm/python/nnvm/frontend/mxnet.py
Outdated
new_attrs['alpha'] = attrs.get('alpha', 0.0001) | ||
new_attrs['beta'] = attrs.get('beta', 0.75) | ||
new_attrs['bias'] = attrs.get('knorm', 2) | ||
new_attrs['axis'] = attrs.get('axis', 1) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could directly assign axis as mxnet never give this attribute.
Also suggest give a hint about why axis is 1.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a minor comment. Other parts look good to me.
@@ -163,3 +168,4 @@ def test_forward_pooling(): | |||
test_forward_split_squeeze() | |||
test_forward_expand_dims() | |||
test_forward_pooling() | |||
test_forward_lrn() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a new line at the end of file.
ff9fbb6
to
ccf91a0
Compare
@kazum @srkreddy1238 Review comments are handled now. Pls check. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @PariksheetPinjari909 .
LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks!
Thanks @PariksheetPinjari909 @kazum @srkreddy1238 , this is merged |
This PR adds LRN support in MXNET frontend
@kazum @srkreddy1238 pls review.