Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Relay] Adding _contrib_BilinearResize2D op from mxnet #2777

Merged
merged 3 commits into from
Mar 17, 2019
Merged

[Relay] Adding _contrib_BilinearResize2D op from mxnet #2777

merged 3 commits into from
Mar 17, 2019

Conversation

Laurawly
Copy link
Contributor

Thanks for contributing to TVM! Please refer to guideline https://docs.tvm.ai/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from Reviewers.

@Laurawly Laurawly requested review from yzhliu and vinx13 March 11, 2019 17:56
srkreddy1238
srkreddy1238 requested changes Mar 12, 2019
View reviewed changes
python/tvm/relay/frontend/mxnet.py Outdated Show resolved Hide resolved
@Laurawly Laurawly force-pushed the dev2 branch 2 times, most recently from da6985e to e2dbbf2 Compare March 13, 2019 06:20
@yzhliu
Copy link
Member

yzhliu commented Mar 15, 2019 •
edited
Loading

Thanks @Laurawly @srkreddy1238 @vinx13 I believe the comment has been addressed. Please confirm @srkreddy1238

@Laurawly
Copy link
Contributor Author

@srkreddy1238 Can you update your review please?

srkreddy1238
srkreddy1238 approved these changes Mar 17, 2019
View reviewed changes
Copy link
Contributor

@srkreddy1238 srkreddy1238 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Laurawly.

@yzhliu yzhliu merged commit 011f0b6 into apache:master Mar 17, 2019
@FrozenGene
Copy link
Member

FrozenGene commented Mar 19, 2019 •
edited
Loading

Hey, @Laurawly I find this PR has some issue after my usage in MXNet (1.4.0).

Firstly, MXNet resize_bilinear compute always align_corners=True. we should set align_corners=True in _op.image.resize.

Secondly, if we have network like data -> resize bilinear. i.e. data is tvm.relay.expr.Var, inputs[0] don't have shape. otherwise we will get: '<class 'tvm.relay.expr.Var'>' object has no attribute 'shape'

so, for the scale_height / scale_width, maybe we should consider how to handle this situation, such as extend parameters to support it

Thirdly, _op.nn.image's size accepts (output_height, output_width). not 4D (N, C, output_height, output_width).

Could you make a new PR and write unit testing compared with MXNet? Thanks in advance. Wish you could reply, because it affects correctness!

@Laurawly
Copy link
Contributor Author

@FrozenGene Yes I also find the error. I'll send a PR accordingly.

wweic pushed a commit to wweic/tvm that referenced this pull request Mar 20, 2019
@Laurawly @wweic
[Relay] Adding _contrib_BilinearResize2D op from mxnet (apache#2777)
80e2896 
* adding _contrib_BilinearResize2D op from mxnet

* error fixed

* use resize instead of upsample
wweic pushed a commit to neo-ai/tvm that referenced this pull request Mar 20, 2019
@Laurawly @wweic
[Relay] Adding _contrib_BilinearResize2D op from mxnet (apache#2777)
a159ad3 
* adding _contrib_BilinearResize2D op from mxnet

* error fixed

* use resize instead of upsample
@Laurawly Laurawly deleted the dev2 branch March 22, 2019 20:28
icemelon pushed a commit that referenced this pull request Apr 2, 2019
@Laurawly @icemelon
[Bugfix] Bilinear resize bug fix from PR #2777 (#2857)
1dab4dc 
* error fixed

* rename

* solve conlicts with master

* more test added

* fix error

* remove test

* comment addressed
ajtulloch pushed a commit to ajtulloch/tvm that referenced this pull request Apr 5, 2019
@Laurawly @ajtulloch
[Bugfix] Bilinear resize bug fix from PR apache#2777 (apache#2857)
9550f62 
* error fixed

* rename

* solve conlicts with master

* more test added

* fix error

* remove test

* comment addressed
wweic pushed a commit to wweic/tvm that referenced this pull request Apr 7, 2019
@Laurawly @wweic
[Bugfix] Bilinear resize bug fix from PR apache#2777 (apache#2857)
21443b2 
* error fixed

* rename

* solve conlicts with master

* more test added

* fix error

* remove test

* comment addressed
wweic pushed a commit to wweic/tvm that referenced this pull request Apr 7, 2019
@Laurawly @wweic
[Bugfix] Bilinear resize bug fix from PR apache#2777 (apache#2857)
ce8f310 
* error fixed

* rename

* solve conlicts with master

* more test added

* fix error

* remove test

* comment addressed
wweic pushed a commit to wweic/tvm that referenced this pull request Apr 8, 2019
@Laurawly @wweic
[Bugfix] Bilinear resize bug fix from PR apache#2777 (apache#2857)
c377338 
* error fixed

* rename

* solve conlicts with master

* more test added

* fix error

* remove test

* comment addressed
wweic pushed a commit to wweic/tvm that referenced this pull request Apr 10, 2019
@Laurawly @wweic
[Bugfix] Bilinear resize bug fix from PR apache#2777 (apache#2857)
1ea177f 
* error fixed

* rename

* solve conlicts with master

* more test added

* fix error

* remove test

* comment addressed
wweic pushed a commit to neo-ai/tvm that referenced this pull request Apr 11, 2019
@Laurawly @wweic
[Bugfix] Bilinear resize bug fix from PR apache#2777 (apache#2857)
2e5a5c6 
* error fixed

* rename

* solve conlicts with master

* more test added

* fix error

* remove test

* comment addressed
@tqchen tqchen mentioned this pull request Nov 8, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yzhliu yzhliu yzhliu approved these changes

@vinx13 vinx13 vinx13 approved these changes

@srkreddy1238 srkreddy1238 srkreddy1238 approved these changes

Assignees

@yzhliu yzhliu

Labels
status: accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Laurawly @yzhliu @FrozenGene @vinx13 @srkreddy1238