Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RPC] Better handle tempdir if subprocess killed. #3574

Merged
merged 1 commit into from
Jul 19, 2019
Merged

[RPC] Better handle tempdir if subprocess killed. #3574

merged 1 commit into from
Jul 19, 2019

Conversation

cbalint13
Copy link
Contributor

@cbalint13 cbalint13 commented Jul 18, 2019 •
edited
Loading

This PR enhance temporary directories and subcontent handling for RPC server.

Description:

  • It fix "no space left" for small devices like rk3399 or rpi where disk space is scarce, or even worse the very /tmp is a ramdisk:
[root@rk3399 tmp]# df -h | grep '/tmp'
none            1.9G  168K  1.9G   1% /tmp

Fixes:

  1. In case of timeout (quite frequent) the RPC subprocess join(timeout) receive SIGTERM so have no chance to clean, but root process can do the cleaning instead.
  2. In case of untar-ing, make sure unpacking occur in already existing root temporary no need another new one (will be not cleaned at SIGTERM), thus this new root temporary can be erased too by the master process.

@eqy, @zhiics, @vinx13, @kevinthesun
Can help review ?

Thank you !

tqchen
tqchen requested changes Jul 18, 2019
View reviewed changes
Copy link
Member

@tqchen tqchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also fix the lint error

python/tvm/contrib/util.py Show resolved Hide resolved
@cbalint13
Copy link
Contributor Author

Please also fix the lint error

It is fixed now.

@tqchen tqchen merged commit 6b5fbda into apache:master Jul 19, 2019
@tqchen
Copy link
Member

tqchen commented Jul 19, 2019

Thanks @cbalint13 , this PR is now merged

@cbalint13 cbalint13 mentioned this pull request Jul 30, 2019
Merged
wweic pushed a commit to wweic/tvm that referenced this pull request Aug 9, 2019
@cbalint13 @wweic
[RPC] Better handle tempdir if subprocess killed. (apache#3574)
7a7c5fe
wweic pushed a commit to neo-ai/tvm that referenced this pull request Sep 6, 2019
@cbalint13 @wweic
[RPC] Better handle tempdir if subprocess killed. (apache#3574)
bba856d
@yzhliu yzhliu mentioned this pull request Nov 11, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tqchen tqchen tqchen approved these changes

Assignees
No one assigned
Labels
status: accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cbalint13 @tqchen