Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Rust] Fix memory leak #2 #8725

Merged
merged 13 commits into from
Aug 24, 2021
Merged

[Rust] Fix memory leak #2 #8725

merged 13 commits into from
Aug 24, 2021

Commits on Aug 23, 2021

  1. Add C++ API for computing type key from type index

    @jroesch
    jroesch committed Aug 23, 2021
    Configuration menu
    Copy the full SHA
    db6eb0f View commit details
    Browse the repository at this point in the history

  2. Try and isolate leak

    @jroesch
    jroesch committed Aug 23, 2021
    Configuration menu
    Copy the full SHA
    3a131b7 View commit details
    Browse the repository at this point in the history

  3. Rewrite the bindings to fix the ArgValue lifetime issue 

    There are still quite a few issues left to resolve in this patch, but I believe the runtime
changes stablize memory consumption as long as the parameters are only set once. ByteArray
also has some totally broken unsafe code which I am unsure of how it was introduced.
    @jroesch
    jroesch committed Aug 23, 2021
    Configuration menu
    Copy the full SHA
    8226ca3 View commit details
    Browse the repository at this point in the history

  4. Finish handling tvm-rt issues due to ArgValue lifetime 

    This patch further refactors the bindings to better handle the
lifetime issues introduced by detecting the argument memory leak.
    @jroesch
    jroesch committed Aug 23, 2021
    Configuration menu
    Copy the full SHA
    1e4edfe View commit details
    Browse the repository at this point in the history

  5. WIP memory leak

    @jroesch
    jroesch committed Aug 23, 2021
    Configuration menu
    Copy the full SHA
    109545a View commit details
    Browse the repository at this point in the history

  6. There is issue using TVMCb function which is breaking refcount

    @jroesch
    jroesch committed Aug 23, 2021
    Configuration menu
    Copy the full SHA
    4da8326 View commit details
    Browse the repository at this point in the history

  7. Fix fallout from the lifetime refactor

    @jroesch
    jroesch committed Aug 23, 2021
    Configuration menu
    Copy the full SHA
    9c308e7 View commit details
    Browse the repository at this point in the history

  8. Another tweak

    @jroesch
    jroesch committed Aug 23, 2021
    Configuration menu
    Copy the full SHA
    dfb0add View commit details
    Browse the repository at this point in the history

  9. Follow up work from the memory leak, attempt to clean up ByteArray

    @jroesch
    jroesch committed Aug 23, 2021
    Configuration menu
    Copy the full SHA
    4912a52 View commit details
    Browse the repository at this point in the history

  10. Add some todos for future work

    @jroesch
    jroesch committed Aug 23, 2021
    Configuration menu
    Copy the full SHA
    53dac41 View commit details
    Browse the repository at this point in the history

  11. Fix doc string

    @jroesch
    jroesch committed Aug 23, 2021
    Configuration menu
    Copy the full SHA
    1a3e1e5 View commit details
    Browse the repository at this point in the history

  12. Clean up the changes

    @jroesch
    jroesch committed Aug 23, 2021
    Configuration menu
    Copy the full SHA
    5a90e2f View commit details
    Browse the repository at this point in the history

  13. Format

    @jroesch
    jroesch committed Aug 23, 2021
    Configuration menu
    Copy the full SHA
    b6ecf60 View commit details
    Browse the repository at this point in the history