chore: refactor addon controller #7819
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
zhuyi1159
commented
Jul 16, 2024
apecloud-bot
added
pre-approve
zhuyi1159
requested review from
nayutah,
ldming,
heng4fun,
free6om,
wangyelei,
Y-Rookie and
weicao
as code owners
free6om
reviewed
Jul 17, 2024
Y-Rookie
reviewed
Jul 18, 2024
apecloud-bot
added
pre-approve
|
Please explain the reasons for refactoring in the description. |
apecloud-bot
added
pre-approve
apecloud-bot
added
pre-approve
weicao
reviewed
Aug 21, 2024
| @@ -202,17 +164,23 @@ func (r *AddonReconciler) deleteExternalResources(reqCtx intctrlutil.RequestCtx, | |||
| } | |||
| job := &batchv1.Job{} | |||
| if err := r.Get(reqCtx.Ctx, key, job); err != nil { | |||
| fmt.Println("not found: ", jobName) | |||
There was a problem hiding this comment.
should not use fmt.Println to print log
apecloud-bot
added
pre-approve
zhuyi1159
force-pushed
the
support/refactor-addon-controller
branch
from
669da4e
to
56cd472
Compare
apecloud-bot
added
pre-approve
…rvation of current status
…s of the addon job
zhuyi1159
force-pushed
the
support/refactor-addon-controller
branch
from
abf6178
to
f2c0f6d
Compare
apecloud-bot
added
pre-approve
apecloud-bot
added
pre-approve
zhuyi1159
force-pushed
the
support/refactor-addon-controller
branch
from
6b0c228
to
21ba3f2
Compare
apecloud-bot
added
pre-approve
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #7678
Currently addon controller is based on state machine, which may not reflect the latest status of the addon and has low readability. This pr is aimed to refactor addon controller with kubebuilderx framework and switch from monitoring the addon.status.phase to monitoring the latest status of the addon job to ensure the timeliness of status updates.