feat: allow pod in place update to cowork with mutating admission webhook #7869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fantasy-yzj
requested review from
nayutah,
ldming,
heng4fun,
free6om,
wangyelei,
Y-Rookie and
weicao
as code owners
|
|
fantasy-yzj
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7869 +/- ##
==========================================
- Coverage 63.39% 63.33% -0.06%
==========================================
Files 339 339
Lines 41424 41438 +14
==========================================
- Hits 26259 26245 -14
- Misses 12834 12870 +36
+ Partials 2331 2323 -8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
weicao
changed the title
weicao
reviewed
Jul 25, 2024
| @@ -261,7 +261,10 @@ func equalBasicInPlaceFields(old, new *corev1.Pod) bool { | |||
|
|
|||
| func equalResourcesInPlaceFields(old, new *corev1.Pod) bool { | |||
There was a problem hiding this comment.
old -> current
new -> expected
is better
weicao
reviewed
Jul 25, 2024
fantasy-yzj
force-pushed
the
support/improvement-allow-pod-in-place-update-to-cowork-with-mutating-admission-webhook
branch
from
aeca824
to
dcd4689
Compare
zjx20
reviewed
Sep 10, 2024
| @@ -259,7 +259,10 @@ func equalBasicInPlaceFields(old, new *corev1.Pod) bool { | |||
|
|
|||
| func equalResourcesInPlaceFields(old, new *corev1.Pod) bool { | |||
| if len(old.Spec.Containers) != len(new.Spec.Containers) { | |||
There was a problem hiding this comment.
I think we can simply remove this if-statement to support the case.
The following for-loop will make sure that all containers in the new pod are present in the old pod and have the same resources, so if a new container is added to the new pod, the function returns false, which causes a pod recreation. But if the old pod contains unknown containers (injected by external webhooks), the function will still return true, which causes an in-place update.
fantasy-yzj
force-pushed
the
support/improvement-allow-pod-in-place-update-to-cowork-with-mutating-admission-webhook
branch
from
dcd4689
to
14c097b
Compare
github-actions
bot
added
size/S
zjx20
reviewed
Sep 13, 2024
| @@ -258,9 +258,6 @@ func equalBasicInPlaceFields(old, new *corev1.Pod) bool { | |||
| } | |||
|
|
|||
| func equalResourcesInPlaceFields(old, new *corev1.Pod) bool { | |||
There was a problem hiding this comment.
Suggested change
| func equalResourcesInPlaceFields(old, new *corev1.Pod) bool { | |
| // equalResourcesInPlaceFields checks if the desired values of pod resources are equal to their current actual values. If they are equal, it returns true. Containers in 'old' that are not recognized (they may have been injected by external mutating admission webhooks) will not participate in the comparison. | |
| func equalResourcesInPlaceFields(old, new *corev1.Pod) bool { |
| @@ -198,6 +198,28 @@ var _ = Describe("instance util test", func() { | |||
| policy, err = getPodUpdatePolicy(its, pod5) | |||
| Expect(err).Should(BeNil()) | |||
| Expect(policy).Should(Equal(NoOpsPolicy)) | |||
|
|
|||
| By("build a pod without revision updated, with IgnorePodVerticalScaling disabled") | |||
There was a problem hiding this comment.
Suggested change
| By("build a pod without revision updated, with IgnorePodVerticalScaling disabled") | |
| By("simulating a webhook to add an unknown container to the pod, with IgnorePodVerticalScaling disabled, it should use the in-place update policy") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.