feat: redis-restore-by-keys #8129
Conversation
Chiwency
requested review from
nayutah,
ldming,
heng4fun,
free6om,
wangyelei and
Y-Rookie
as code owners
pkg/controller/plan/restore.go
Outdated
| @@ -360,6 +363,9 @@ func (r *RestoreManager) initFromAnnotation(synthesizedComponent *component.Synt | |||
| if doReadyRestoreAfterClusterRunning == "true" { | |||
| r.doReadyRestoreAfterClusterRunning = true | |||
| } | |||
| if env := backupSource[constant.EnvForRestore]; env != "" { | |||
| json.Unmarshal([]byte(env), &r.env) | |||
There was a problem hiding this comment.
Return the error when unmarshal fails. It should rarely happen.
There was a problem hiding this comment.
If a error occurs, the r.env will be remained empty, should we still need to handle this err?
There was a problem hiding this comment.
If the env cannot be deserialized, we may not be able to restore the data as expected by the user (e.g., ignoring user-specified restore keys). The result of the restoration is unpredictable, so it is reasonable to fail the restoration directly.
|
Please run |
apecloud-bot
added
pre-approve
apecloud-bot
added
pre-approve
apecloud-bot
added
pre-approve
|
@wangyelei @ldming Please take a look. |
|
@Chiwency Thanks for the contribution! Please issue another PR to merge the changes into the main branch. |
Resolve #8128
Support redis restore by multiply key patterns.
We can apply the key restoration by
"a*" and "b*" represent the patterns of keys we want to restore, and split by comma.
for the details of the key pattern, refer to Redis/KEYS
Implementation
DP_RESTORE_KEY_PATTERNS.by pattern then MIGRATE the selected keys to the target redis instance.