Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: specify node for rebuild instance ops #8161

Merged
merged 2 commits into from
Sep 19, 2024

Conversation

cjc7373
Copy link
Contributor

@cjc7373 cjc7373 commented Sep 18, 2024

cherry-picked from 87e27f5

@github-actions github-actions bot added the size/L Denotes a PR that changes 100-499 lines. label Sep 18, 2024
Copy link

codecov bot commented Sep 18, 2024

Codecov Report

Attention: Patch coverage is 54.45545% with 46 lines in your changes missing coverage. Please review.

Project coverage is 65.16%. Comparing base (e7f8efc) to head (9d6c00d).
Report is 1 commits behind head on release-0.9.

Files with missing lines Patch % Lines
pkg/controller/instanceset/instance_util.go 59.61% 15 Missing and 6 partials ⚠️
controllers/apps/operations/rebuild_instance.go 58.33% 7 Missing and 3 partials ⚠️
...ollers/apps/operations/rebuild_instance_inplace.go 40.00% 6 Missing and 3 partials ⚠️
pkg/controller/instanceset/reconciler_status.go 40.00% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           release-0.9    #8161      +/-   ##
===============================================
+ Coverage        64.98%   65.16%   +0.18%     
===============================================
  Files              358      358              
  Lines            45004    45096      +92     
===============================================
+ Hits             29246    29387     +141     
+ Misses           13151    13114      -37     
+ Partials          2607     2595      -12     
Flag Coverage Δ
unittests 65.16% <54.45%> (+0.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@apecloud-bot apecloud-bot added the approved PR Approved Test label Sep 19, 2024
@cjc7373
Copy link
Contributor Author

cjc7373 commented Sep 19, 2024

/approve

@cjc7373 cjc7373 merged commit 877b18d into release-0.9 Sep 19, 2024
38 checks passed
@cjc7373 cjc7373 deleted the support/pick-specify-node-rebuild branch September 19, 2024 02:56
@github-actions github-actions bot added this to the Release 0.9.2 milestone Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved PR Approved Test size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants