chore: update the group of the ops to "operations" #8162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wangyelei
requested review from
michelle-0808,
shanshanying,
a team,
ldming,
zjx20,
sophon-zt,
leon-inf and
Y-Rookie
as code owners
wangyelei
force-pushed
the
feature/update_ops_group
branch
from
d350939
to
f5f00d1
Compare
leon-inf
reviewed
Sep 19, 2024
| package v1alpha1 | ||
|
|
||
| import ( | ||
| kbappsv1 "github.com/apecloud/kubeblocks/apis/apps/v1" |
| @@ -39,6 +39,7 @@ import ( | |||
| "sigs.k8s.io/controller-runtime/pkg/reconcile" | |||
|
|
|||
| appsv1alpha1 "github.com/apecloud/kubeblocks/apis/apps/v1alpha1" | |||
| opssv1alpha1 "github.com/apecloud/kubeblocks/apis/operations/v1alpha1" | |||
There was a problem hiding this comment.
opssv1alpha1 -> opsv1alpha1
| @@ -39,6 +39,7 @@ import ( | |||
| "sigs.k8s.io/controller-runtime/pkg/reconcile" | |||
|
|
|||
| appsv1alpha1 "github.com/apecloud/kubeblocks/apis/apps/v1alpha1" | |||
| opssv1alpha1 "github.com/apecloud/kubeblocks/apis/operations/v1alpha1" | |||
There was a problem hiding this comment.
BTW, it's weird that configuration controllers depends on types that defined by ops.
| @@ -157,7 +158,7 @@ func kindsForHalt() ([]client.ObjectList, []client.ObjectList) { | |||
| namespacedKinds, nonNamespacedKinds := kindsForDoNotTerminate() | |||
| namespacedKindsPlus := []client.ObjectList{ | |||
| &kbappsv1.ComponentList{}, | |||
| &appsv1alpha1.OpsRequestList{}, | |||
| &opssv1alpha1.OpsRequestList{}, | |||
There was a problem hiding this comment.
Ops is on top of the cluster and operates on the cluster, so its resources should not be deleted by the cluster controller.
| @@ -24,6 +24,7 @@ import ( | |||
| "sigs.k8s.io/controller-runtime/pkg/client" | |||
|
|
|||
| appsv1alpha1 "github.com/apecloud/kubeblocks/apis/apps/v1alpha1" | |||
| opssv1alpha1 "github.com/apecloud/kubeblocks/apis/operations/v1alpha1" | |||
There was a problem hiding this comment.
opssv1alpha1 -> opsv1alpha1
| @@ -47,6 +47,7 @@ import ( | |||
| appsv1alpha1 "github.com/apecloud/kubeblocks/apis/apps/v1alpha1" | |||
| appsv1beta1 "github.com/apecloud/kubeblocks/apis/apps/v1beta1" | |||
| dpv1alpha1 "github.com/apecloud/kubeblocks/apis/dataprotection/v1alpha1" | |||
| opsv1alpha1 "github.com/apecloud/kubeblocks/apis/operations/v1alpha1" | |||
| @@ -37,6 +37,7 @@ import ( | |||
| kbappsv1 "github.com/apecloud/kubeblocks/apis/apps/v1" | |||
| appsv1alpha1 "github.com/apecloud/kubeblocks/apis/apps/v1alpha1" | |||
| dpv1alpha1 "github.com/apecloud/kubeblocks/apis/dataprotection/v1alpha1" | |||
| opssv1alpha1 "github.com/apecloud/kubeblocks/apis/operations/v1alpha1" | |||
|
|
||
| const ( | ||
| // name of our custom finalizer | ||
| clusterDefinitionFinalizerName = "clusterdefinition.kubeblocks.io/finalizer" |
| @@ -34,6 +34,7 @@ import ( | |||
| appsv1beta1 "github.com/apecloud/kubeblocks/apis/apps/v1beta1" | |||
| dpv1alpha1 "github.com/apecloud/kubeblocks/apis/dataprotection/v1alpha1" | |||
| extensionsv1alpha1 "github.com/apecloud/kubeblocks/apis/extensions/v1alpha1" | |||
| opssv1alpha1 "github.com/apecloud/kubeblocks/apis/operations/v1alpha1" | |||
There was a problem hiding this comment.
opssv1alpha1 -> opsv1alpha1
| @@ -27,14 +27,14 @@ import ( | |||
| "k8s.io/apimachinery/pkg/types" | |||
There was a problem hiding this comment.
Move the file to operations pkg.
leon-inf
reviewed
Sep 19, 2024
leon-inf
reviewed
Sep 19, 2024
| - api: | ||
| crdVersion: v1 | ||
| namespaced: true | ||
| domain: kubeblocks.io |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.