Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌐 Add malay locale #4087

Merged
merged 3 commits into from
Nov 1, 2023
Merged

🌐 Add malay locale #4087

merged 3 commits into from
Nov 1, 2023

Conversation

iqfareez
Copy link
Contributor

New Pull Request

Add Malay (Malaysia) locale

Fixes #4083

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@junedchhipa
Copy link
Contributor

Hey @iqfareez
You need to add the locale to src/locales, not dist.
The dist folder is automatically generated during the build process. PLease update the PR

@iqfareez
Copy link
Contributor Author

Thanks for pointing out, @junedchhipa. Totally missed that. Changes were made.

@junedchhipa junedchhipa merged commit 4c1a0e7 into apexcharts:main Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(i18n) Add Malay locale (ms)
2 participants