If all series types match the chart type it isn't a combo chart #4327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junedchhipa
requested changes
Mar 16, 2024
The default type for chart is "line" and the default for series is the chart type, therefore, if the types of all series match the chart type, this should not be considered a combo chart.
junedchhipa
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Pull Request
The default type for chart is "line" and the default for series is the chart type, therefore, if the types of all series match the chart type, this should not be considered a combo chart. Previously, if any series had a defined type, the chart was considered a combo chart.
Fixes #4132
The CodePen example in the original bug report will stack correctly with this fix, but as far as I know it doesn't restore the behaviour the reporter claims was working in revisions prior to 3.44.1.
Before
After
Type of change
Checklist: