Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#4541): fixed transparent background not appearing with dark mode #4542

Merged

Conversation

Sebastian-Webster
Copy link
Contributor

Fixed transparent background not appearing with chart in dark mode

Fixed the transparent background not appearing when a chart is in dark mode. Previously it would pull the background colour from the dark theme, and now it gets it from the chart options.

Fixes #4541

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes

@Sebastian-Webster Sebastian-Webster marked this pull request as ready for review June 26, 2024 10:48
@junedchhipa junedchhipa merged commit 4005cd3 into apexcharts:main Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

#4505: Breaks transparent mode if you have a theme set
2 participants