Skip to content
This repository has been archived by the owner on Mar 6, 2024. It is now read-only.

Add airnode-protocol-v1 dependency #58

Merged
merged 2 commits into from
Apr 14, 2022
Merged

Add airnode-protocol-v1 dependency #58

merged 2 commits into from
Apr 14, 2022

Conversation

vponline
Copy link
Contributor

Use airnode-protocol-v1 contracts to get ABI and bytecode

@vponline vponline self-assigned this Apr 13, 2022
vponline
vponline commented Apr 13, 2022
View reviewed changes
test/e2e/psp.feature.ts Outdated Show resolved Hide resolved
acenolaza
acenolaza suggested changes Apr 13, 2022
View reviewed changes
Copy link
Contributor

@acenolaza acenolaza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm really happy to see the hardcoded abi strings gone 🥳

src/evm/initialize-provider.ts Outdated Show resolved Hide resolved
test/e2e/psp.feature.ts Show resolved Hide resolved
@vponline vponline requested a review from acenolaza April 14, 2022 07:41
Siegrift
Siegrift approved these changes Apr 14, 2022
View reviewed changes
Copy link
Contributor

@Siegrift Siegrift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM, glad to +53, -3179 diff :D

acenolaza
acenolaza approved these changes Apr 14, 2022
View reviewed changes
Copy link
Contributor

@acenolaza acenolaza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🏆

Base automatically changed from psp-e2e-test to main April 14, 2022 13:55
@vponline vponline merged commit a053f12 into main Apr 14, 2022
@vponline vponline deleted the use-v1-contracts branch April 14, 2022 14:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@acenolaza acenolaza acenolaza approved these changes

@Siegrift Siegrift Siegrift approved these changes

@amarthadan amarthadan Awaiting requested review from amarthadan

Assignees

@vponline vponline

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vponline @acenolaza @Siegrift