0.9.0 (4) - Add integration test for vitejs + streaming #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phryneas
force-pushed
the
pr/split-packages
branch
2 times, most recently
from
4c5565e
to
fb2bc7e
Compare
phryneas
force-pushed
the
pr/integration-tests
branch
2 times, most recently
from
e6316e8
to
5cbb230
Compare
phryneas
force-pushed
the
pr/integration-tests
branch
from
a0faf01
to
39c90fb
Compare
jerelmiller
approved these changes
Mar 5, 2024
| let vite; | ||
| let bootstrapModules = []; | ||
| let assets = []; | ||
| console.log({ isProduction }); |
There was a problem hiding this comment.
Suggested change
| console.log({ isProduction }); |
| "express": "^4.18.2", | ||
| "graphql": "^16.8.1", | ||
| "graphql-tag": "^2.12.6", | ||
| "react": "npm:@phryneas/experimental-react@0.0.0-phryneas-a1c625c", |
There was a problem hiding this comment.
Is this version still needed in the vite tests? Makes sense for the experimental tests, but wasn't sure about this one.
phryneas
added a commit
that referenced
this pull request
Mar 6, 2024
* add a "jest" integration test * split up into "sub-monorepo" * more logs * move around monorepo link * build deps first * allow updating checksum * ignore checksums in integration tests * mark pattern * call for linux, not osx * rename test runs * fixup * 0.9.0 (4) - Add integration test for vitejs + streaming (#198) * rename wrapped classes to original name, also export in RSC * fix up test * fixup build types * comment shape * adjust type resolution * fixup * adjust package shapes * bundling adjustment: no `/index.js` in CJS * check "package shapes" * revert changes to examples/integration tests * reset README changes * add description to helper scripts * wrap hook functionality from ApolloClient instance * move wrappers to `QueryManager` * update version * remove hook exports from `@apollo/client-react-streaming` * run test-bundle in CI * drop hook exports * move "integration-test" into "integration-test/nextjs" * initialize basic vite react-ssr project * apply prettier * [WIP] try to set up a streaming server * fix hydration, force faster flush * experimental-react demo working * add delay * also works with prod build * update lockfile * global react version * simplify a bit * move experimental detail out to `WrappedApolloProvider` * adjustments * remove `@apollo/client-react-streaming/experimental-react-transport` * alternative installation * alternative approach * fix non-failing tests * fix bug that prevented rerunning hydrated queries if initialized too late * adjust script * more packaging foo * fixup app rendering * playwright test * split up * copy experimental to vite-streaming * adjust types * remove `Writable` from experimental example * vite-streaming * remove insertions after last flush * add pipeTrough * learnings from experimental-react * add steps to workflow * build only libraries in test preparation * review feedback * small fixup * Update integration-test/jest/package.json Co-authored-by: Jerel Miller <jerelmiller@gmail.com> * Update integration-test/jest/src/App.jsx --------- Co-authored-by: Jerel Miller <jerelmiller@gmail.com>
phryneas
added a commit
that referenced
this pull request
Mar 6, 2024
* add a "jest" integration test * split up into "sub-monorepo" * more logs * move around monorepo link * build deps first * allow updating checksum * ignore checksums in integration tests * mark pattern * call for linux, not osx * rename test runs * fixup * 0.9.0 (4) - Add integration test for vitejs + streaming (#198) * rename wrapped classes to original name, also export in RSC * fix up test * fixup build types * comment shape * adjust type resolution * fixup * adjust package shapes * bundling adjustment: no `/index.js` in CJS * check "package shapes" * revert changes to examples/integration tests * reset README changes * add description to helper scripts * wrap hook functionality from ApolloClient instance * move wrappers to `QueryManager` * update version * remove hook exports from `@apollo/client-react-streaming` * run test-bundle in CI * drop hook exports * move "integration-test" into "integration-test/nextjs" * initialize basic vite react-ssr project * apply prettier * [WIP] try to set up a streaming server * fix hydration, force faster flush * experimental-react demo working * add delay * also works with prod build * update lockfile * global react version * simplify a bit * move experimental detail out to `WrappedApolloProvider` * adjustments * remove `@apollo/client-react-streaming/experimental-react-transport` * alternative installation * alternative approach * fix non-failing tests * fix bug that prevented rerunning hydrated queries if initialized too late * adjust script * more packaging foo * fixup app rendering * playwright test * split up * copy experimental to vite-streaming * adjust types * remove `Writable` from experimental example * vite-streaming * remove insertions after last flush * add pipeTrough * learnings from experimental-react * add steps to workflow * build only libraries in test preparation * review feedback * small fixup * Update integration-test/jest/package.json Co-authored-by: Jerel Miller <jerelmiller@gmail.com> * Update integration-test/jest/src/App.jsx --------- Co-authored-by: Jerel Miller <jerelmiller@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an integration test that demonstrates how to use Apollo Client with streaming SSR in Vite.