0.9.0 (2) - wrap hook functionality from ApolloClient instance #216
Conversation
| export const useReadQuery = wrap(orig_useReadQuery, ["data", "networkStatus"]); | ||
|
|
||
| export const useBackgroundQuery = orig_useBackgroundQuery; | ||
| export const hookWrappers: HookWrappers = { |
There was a problem hiding this comment.
We'll never get our "wrapping" code to tree-shake, but that's okay for me.
What's important here is that the upstream hooks can shake out if they are not used.
| @@ -7,7 +7,7 @@ export { | |||
| useSuspenseQuery, | |||
| useReadQuery, | |||
| useBackgroundQuery, | |||
| } from "./hooks.js"; | |||
| } from "@apollo/client/index.js"; | |||
There was a problem hiding this comment.
No more custom implementations & it doesn't matter where it's imported from 🎉
There was a problem hiding this comment.
I'm curious, is there any reason not to just deprecate these exports and have users import directly from @apollo/client? That could simplify things even further 🙂
There was a problem hiding this comment.
Removing it from this package, but keeping it in the "outer" package for now. (Will drop it in a future version.)
| } | ||
|
|
||
| [wrappers] = hookWrappers; |
There was a problem hiding this comment.
See https://github.com/apollographql/apollo-client/pull/11617/files#r1500875764
I'd be curious if we could store this on QueryManager which would make a path for useReadQuery to work in all scenarios.
phryneas
changed the title
phryneas
force-pushed
the
pr/wrapHooks-2
branch
from
ce940ef
to
12b6ff3
Compare
This PR builds on apollographql/apollo-client#11617 and does the same as #215 or #206, but should tree-shake better than #215 and has better UX than #206