Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README links to point to non-experimental hooks links #309

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

jer-k
Copy link
Contributor

@jer-k jer-k commented Jun 5, 2024

Hi, I noticed that the links to useSuspenseQuery and useFragment weren't linking to the proper place. It looks like those hooks got moved out of experimental and are stable now. I updated those links. Looks like my editor also cleared out some trailing whitespace, hopefully that is okay.

@jer-k jer-k requested a review from a team as a code owner June 5, 2024 14:41
@apollo-cla
Copy link

@jer-k: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/

Copy link

netlify bot commented Jun 5, 2024

👷 Deploy request for apollo-client-nextjs-docmodel pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit f1e8030

Copy link
Member

@jerelmiller jerelmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch! Thanks so much for updating this.

@jerelmiller jerelmiller merged commit 4f4124e into apollographql:main Jun 5, 2024
1 of 2 checks passed
@@ -5,8 +5,8 @@
# Apollo Client support for the Next.js App Router

> ❗️ This package is experimental.<br/>
> Generally it should work well, you might run into race conditions when your Client Component is still rendering in SSR, and already making overlapping queries on the browser.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This whitespace was unfortunately very important - in GitHub markdown, two spaces at a line end mark a <br/> tag 😬

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, thats quite a choice by them. It looks like \ also works to add line breaks, would you be okay with a PR that uses those as the more explicit option to get the docs back to the way they were?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jer-k yes! Apologies on my part for not realizing the spaces were intentional. I've got a command to remove trailing whitespace when I save in my editor, so I think the more explicit \ would be welcome :).

Feel free to open a new PR if you'd like, otherwise I can tackle this later today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants