-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
align coprocessor metric creation #4930
Conversation
There are currently 2 different ways to create metrics, with slight incompatibilities. This makes sure that the execution stage coprocessor metrics are generated in the same way as the other stages
This comment has been minimized.
This comment has been minimized.
CI performance tests
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, we're trying to move away from the tracing macros for metrics. They cause a bunch of issues around types, they are slow and also they can't be unit tested. Can we move to the new macros?
There's docs for the new macros here: https://github.com/apollographql/router/blob/dev/dev-docs/metrics.md
the issue appeared because I tried to move to the new macros at the exectution stage. Do you want me to update the other stages instead? |
Yeah let's try and yeet the other metrics macro use. It's generally bad form to have multiple points where a metric is updated as with both the macros there is a risk of collision. The only reason it didn't hit us harder is that the old tracing macros didn't fill out the metric descriptions. In other areas of the code we also had issues with double counting. Ideally we pull out a function that updates the metric and use this in all places in this plugin or alternatively use the regular meter provider to create the meter once and store it in the plugin for reuse at all current callsites. |
There are currently 2 different ways to create metrics, with slight incompatibilities. This makes sure that the execution stage coprocessor metrics are generated in the same way as the other stages
Checklist
Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.
Exceptions
Note any exceptions here
Notes
Footnotes
It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this. ↩
Configuration is an important part of many changes. Where applicable please try to document configuration examples. ↩
Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions. ↩