feature(smokes): Run Smoke Tests on all supported platforms #1980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathanrainer
force-pushed
the
jr/all-the-smokes
branch
30 times, most recently
from
94347c9
to
1e2e0ae
Compare
jonathanrainer
force-pushed
the
jr/all-the-smokes
branch
5 times, most recently
from
98fc461
to
c2c5e5e
Compare
nmoutschen
approved these changes
Jul 15, 2024
This isn't yet supported by GHA but will be within months
jonathanrainer
force-pushed
the
jr/all-the-smokes
branch
from
f6142f5
to
eaeedb8
Compare
Merged
jonathanrainer
added a commit
that referenced
this pull request
Jul 22, 2024
# [0.25.0] - 2024-07-22 ## 🚀 Features - **Enable Retries For Transient Errors Connecting To Graphs/Subgraphs - @jonathanrainer PR #1936** This turns on retries at the HTTP level for connections to graphs/subgraphs to minimize connection resets and cancellations. Also, a new --subgraph-retries flag for rover dev lets you set the number of retries allowed when trying to re-establish a connection. - **Add `--graph-ref` flag to `rover dev` - @dotdat PR #1984** Introduces subgraph mirroring to rover dev. Subgraph mirroring inherits the subgraph routing URLs and schemas from an existing Studio graphref. This makes it easy to spin up a locally running supergraph without maintaining a supergraph config. [See here](https://www.apollographql.com/docs/rover/commands/dev#starting-a-session-from-a-graphos-studio-variant) for more information. ## 🐛 Fixes - **Fixes issues related to passing filenames to `--output` - @jonathanrainer PR #1996** An issue was raised whereby previous versions of Rover supported passing filenames to the `--output` flag but this was broken in v0.24.0. This has now been fixed and the previous functionality restored. ## 🛠 Maintenance - **Expand Smoke Tests To Run On All Supported Platforms - @jonathanrainer PR #1980** - **Fix cron expression, so it runs only once per day - @jonathanrainer PR #1986** - **Ensure we always use the correct version of Federation when testing - @jonathanrainer PR #1987** - **Add manual Smoke test invocation and pin Windows to `npm@9` for testing - @jonathanrainer PR #1989** - **Update apollographql/router to v1.51.0 - @jonathanrainer PR #1988** - **Update node.js packages - @jonathanrainer PR #1979** Includes `@eslint/compat` to v1.1.1, `eslint` to v9.7.0, `node.js` to v20.15.1, `npm` to v10.8.2 and `prettier` to v3.3.3 - **Make sure x86 Mac Tests use 'latest' supergraph plugin version - @jonathanrainer PR #1990** - **Make sure homebrew runs `brew update` when we use it - @jonathanrainer PR #1993** ## 📚 Documentation - **Adds `graph-ref` flag to dev subcommand docs - @jackonawalk PR #1945** - **Update schema proposals capabilities docs - @Meschreiber PR #1949**
This was referenced Sep 11, 2024
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we have smoke testing established for
rover devthis rolls it out to all the supported architectures.At the moment the workflow is triggered via a cron at 9am each day, so as to test whether it's robust before we start gating PRs behind it etc. When it triggers it calculates the 3 latest (non-pre-release) versions of
routerandsupergraphand forms a matrix with those and the supported OS's.Those supported OSes are:
Originally there were plans to test in a
glibc 2.17environment, howeverrouterbinaries do not work here (context: https://apollograph.slack.com/archives/C02UX05LF4K/p1721026197480029) so this has been scaled back, as well as the plans to testmuslcompiled binaries because of the lack ofsupergraphbinaries.A fully successful run can be seen here: https://github.com/apollographql/rover/actions/runs/9938343741/job/27452394532