Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix auth header for urls not having an @ symbol #137

Closed
divyanshu013 opened this issue Nov 3, 2017 · 1 comment
Closed

Fix auth header for urls not having an @ symbol #137

divyanshu013 opened this issue Nov 3, 2017 · 1 comment
Assignees
@divyanshu013
Labels
bug
Milestone
1.3.0

Comments

@divyanshu013
Copy link
Contributor

Tell us where you are using Dejavu (Hosted web app, Chrome extension, Docker Image, Within appbase.io)

appbase.io

What is the version of Dejavu that you are using?

1.2

Describe the issue that you are seeing, or the feature request :-), include any screenshots as necessary.

The auth header is being wrongly set in URLs not having an @ symbol. This causes some issues while sending POST requests (also leading to 403 Forbidden on a local ES cluster). We should only set auth header if a valid URL is present.
@divyanshu013 divyanshu013 added this to the 1.3.0 milestone Nov 3, 2017
@divyanshu013 divyanshu013 self-assigned this Nov 3, 2017
@divyanshu013
Copy link
Contributor Author

Resolved in 9ae2103

siddharthlatest pushed a commit that referenced this issue Nov 3, 2017
@divyanshu013
Resolve #137 adds global sort
f7bdfe4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@divyanshu013 divyanshu013

Labels
bug
Projects
None yet
Milestone
1.3.0
Development

No branches or pull requests
1 participant
@divyanshu013