Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[$50] Avoid reloading file icons in the Assets Library #3211

Closed
maxceem opened this issue Jul 23, 2019 · 4 comments
Closed

[$50] Avoid reloading file icons in the Assets Library #3211

maxceem opened this issue Jul 23, 2019 · 4 comments
Assignees
@suppermancool
Labels
ACCEPTED P3
Milestone
2.4.15

Comments

@maxceem
Copy link
Collaborator

maxceem commented Jul 23, 2019 •
edited
Loading

Expected behavior

Icons for files should be loaded only once.

Actual behavior

Every time when we hide/show some folder on the Assets Library page, the icons for files are reloading and blinking.

Steps to reproduce the problem

  • Open any project's Assets Library page with some files uploaded, for example, https://connect.topcoder-dev.com/projects/7977/assets
  • Observe that icons for files are loaded.
  • Open dev tools to watch network calls.
  • Switch to the Links tab and switch back to the files tab.
  • Observe that icons for files are loaded again in the Network tab of the dev tools. And also visually we can see, that icons are not shown initially when we switch back to the files tab.

Screenshot/screencast

Demo video: https://monosnap.com/file/MDgmQKiY0VUCUCukXtNqnURA1EZLsc

image

--

Environment

  • OS: any
  • Browser (w/version): any
  • User role (client, copilot or manager): any
  • Account used: pshah_manager
@maxceem maxceem added the P3 label Jul 23, 2019
@vikasrohit
Copy link

Good catch @maxceem

@vikasrohit vikasrohit added this to the Connect 2.4.14 milestone Jul 23, 2019
@vikasrohit vikasrohit modified the milestones: Connect 2.4.14, 2.4.15 Sep 9, 2019
@maxceem maxceem changed the title Avoid reloading file icons in the Assets Library [$50] Avoid reloading file icons in the Assets Library Sep 19, 2019
@maxceem maxceem added Open for Pickup CF Issue for Community Fixes in the current Bug Bash and removed cf-pipeline labels Sep 19, 2019
@suppermancool
Copy link
Contributor

@maxceem pls assign this to me

suppermancool added a commit to suppermancool/appirio-tech-connect-app that referenced this issue Sep 19, 2019
@suppermancool
Avoid reloading file icons in the Assets Library appirio-tech#3211
73ff7c7 
Avoid reloading file icons in the Assets Library appirio-tech#3211
@suppermancool suppermancool mentioned this issue Sep 19, 2019
Merged
@suppermancool
Copy link
Contributor

@maxceem done in #3316

maxceem added a commit that referenced this issue Sep 23, 2019
@maxceem
Merge pull request #3316 from suppermancool/issue-3211
3b1b1f5 
Avoid reloading file icons in the Assets Library #3211
maxceem added a commit that referenced this issue Sep 23, 2019
@maxceem
Revert "Avoid reloading file icons in the Assets Library #3211"
7146031
maxceem added a commit that referenced this issue Sep 23, 2019
@maxceem
Merge pull request #3330 from appirio-tech/revert-3316-issue-3211
73b6d9c 
Revert "Avoid reloading file icons in the Assets Library #3211"
maxceem added a commit that referenced this issue Sep 23, 2019
@maxceem
Merge pull request #3331 from suppermancool/issue-3211
df99c80 
Issue #3211
RishiRajSahu added a commit that referenced this issue Sep 25, 2019
@RishiRajSahu
Merge branch 'feature/registration_and_profile_page_improvements' of h…
9f4253f 
…ttps://github.com/appirio-tech/connect-app into feature/registration_and_profile_page_improvements

* 'feature/registration_and_profile_page_improvements' of https://github.com/appirio-tech/connect-app:
  added checkbox to the list of accordion enclosable components.
  feat: failing loading members shouldn't break showing project list
  feat: unified checkPermission method with support of "allowRoles"/"denyRoles"
  Revert "Avoid reloading file icons in the Assets Library #3211"
  revert unnessary code
  update comment
  import file icon for avoid reloading
  Avoid reloading file icons in the Assets Library #3211
  feat: hide nodes in the wizard based on "userPermissionCondition"
  feat: subSection type "portal" supports "hiddenCondition" and "hiddenOnEdit"
  fix: show the first section in `PortalSubSection` if configured
  Github issue#3304, P2: Update Empty Plan Message to Client — Done
  GitHub issue#3302, Remove "System" Label in Left Sidebar — Done.
  feat: provide dummy value for FILE_PICKER_API_KEY
  Added csv as acceptable file format
maxceem added a commit that referenced this issue Oct 1, 2019
@maxceem
fix: Avoid reloading file icons in the Assets Library
41dd174 
ref issue #3211
@maxceem maxceem mentioned this issue Oct 1, 2019
Merged
@vikasrohit
Copy link

Release to production.

@maxceem maxceem removed the CF Issue for Community Fixes in the current Bug Bash label Jan 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@suppermancool suppermancool

Labels
ACCEPTED P3
Projects
None yet
Milestone
2.4.15
Development

No branches or pull requests
3 participants
@maxceem @vikasrohit @suppermancool