Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$15] UI issue when we invite a member with a long email #3842

Closed
codejamtc opened this issue Apr 2, 2020 · 18 comments
Closed

[$15] UI issue when we invite a member with a long email #3842

codejamtc opened this issue Apr 2, 2020 · 18 comments
Assignees
Labels
ACCEPTED CF Issue for Community Fixes in the current Bug Bash P4 PAID Prod Environment Issue Reported in Production Environment QA Pass in Prod UI
Milestone

Comments

@codejamtc
Copy link
Collaborator

Expected behavior

The email should be trimmed

Actual behavior

UI issue when we invite a member with a long email

Steps to reproduce the problem

Screenshot/screencast

image
image

Environment

  • OS: Window 10
  • Browser (w/version): Chrome 80.0.3987.149 (Official Build) (64-bit)
  • User role (client, copilot or manager): Customer
  • Account used: CustomerUser
@codejamtc codejamtc added UI Prod Environment Issue Reported in Production Environment P4 labels Apr 2, 2020
@codejamtc codejamtc added this to the 2.9 milestone Apr 2, 2020
@codejamtc codejamtc modified the milestones: 2.9, 2.10 Apr 13, 2020
@maxceem
Copy link
Collaborator

maxceem commented Apr 16, 2020

In the tooltip we have to make sure, that:

  • email or username is cut, so the Invite level is visible, see how it's visible when email or username is short:

    invite by username:

    image

    invite by email:

    image

  • when email or username is cut, we should show an ellipsis ... at the end

In the dialog:

  • if we invite user by email, it's already cut, but we have to show elliplisi ... at the ned, now we don't show it:

    image

In your PR, please add screenshots on every of 3 cases.

@maxceem maxceem modified the milestones: 2.10, 2.9 Apr 16, 2020
@maxceem maxceem added CF Issue for Community Fixes in the current Bug Bash Open for Pickup labels Apr 16, 2020
@maxceem maxceem changed the title UI issue when we invite a member with a long email [$15] UI issue when we invite a member with a long email Apr 16, 2020
@maxceem
Copy link
Collaborator

maxceem commented Apr 16, 2020

This issue is open for pickup.

@nahidshahin
Copy link
Contributor

@bug-bash-helper assign

@bug-bash-hunt-helper
Copy link

@nahidshahin ✅ you are now assigned to this issue and have 12 hours to complete it.

As soon as you are done, please, make a comment like below, including the link to the pull request:

@bug-bash-helper <link to PR> is ready for review

@nahidshahin
Copy link
Contributor

@bug-bash-helper #3918 is ready for review

@bug-bash-hunt-helper
Copy link

@nahidshahin ✅ this issue is marked as Ready for Review.

Now you may pick up another issue which is open for pickup if you like to.

maxceem added a commit that referenced this issue Apr 18, 2020
issues #3842: showing ellipsis ... at the end
@codejamtc
Copy link
Collaborator Author

@codejamtc
Copy link
Collaborator Author

Partial QA pass in Production: ⚠️

image

image

Failed in Firefox @maxceem @vikasrohit

image

@maxceem
Copy link
Collaborator

maxceem commented Apr 29, 2020

@vikasrohit how to proceed if issue indeed failed in some case?
Create a new issue for the next release?
Or just keep the current issue as failed and fix it in the next release again?
Or fix it as a hotfix?

@codejamtc
Copy link
Collaborator Author

Fixed in Dev: 🆗

image

@drasticdpk
Copy link
Collaborator

Same issue on prod env /Firefox.
@maxceem how do we know if the issue is ready for prod testing or not ? Can we add new label 'Ready For Prod QA', please suggest.
image

@maxceem
Copy link
Collaborator

maxceem commented May 4, 2020

@drasticdpk I guess we can let you know on Slack when it's ready for testing as we don't have a special label for this.

@maxceem
Copy link
Collaborator

maxceem commented May 4, 2020

@vikasrohit @lakshmiathreya should we have a special label for such situations?

@vikasrohit vikasrohit modified the milestones: 2.9, 2.9.1 May 6, 2020
@drasticdpk
Copy link
Collaborator

drasticdpk commented May 6, 2020

QA Fail on prod env.
image

@maxceem
Copy link
Collaborator

maxceem commented May 6, 2020

@drasticdpk issues in milestone 2.9.1 https://github.com/appirio-tech/connect-app/milestone/92 are not yet deployed to PROD.

@vikasrohit
Copy link

Can we add new label 'Ready For Prod QA', please suggest.

@drasticdpk @maxceem I don't think we need such label, it would just increase the work for dev team. We are already making notifications about release in Slack with the details of release which has the milestone as well, so it should be pretty straightforward to start testing for certain milestone on prod after we have notified the successful release in Slack.

@drasticdpk
Copy link
Collaborator

Verified on prod env
image

We are already making notifications about release in Slack with the details of release which has the milestone as well, so it should be pretty straightforward to start testing for certain milestone on prod after we have notified the successful release in Slack.

Ok noted cc @vikasrohit

@lakshmiathreya
Copy link

Admin view in Prod :
Screenshot 2020-05-07 at 1 03 41 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ACCEPTED CF Issue for Community Fixes in the current Bug Bash P4 PAID Prod Environment Issue Reported in Production Environment QA Pass in Prod UI
Projects
None yet
Development

No branches or pull requests

6 participants