Direct and Salesforce Links are not visible to the Account Manager after joining to the project

[codejamtc]

Expected behavior

Should be visible and should be able to access them without an issue

Actual behavior

Direct and Salesforce Links are not visible to the Account Manager after joining to the project

Steps to reproduce the problem

• Login as Account Manager
• Select a project from the list {https://connect.topcoder-dev.com/projects/9173}
• Go to Topcoder Team > Join Project > Join Project button
• Check the Administration section Direct and Salesforce Links

Screenshot/screencast

https://monosnap.com/file/8eOPc2rbeoFD9P3WkB52YxVmciA7Gz

Environment

- OS: HP 15-dw1xxx 15.6 inch; Window 10
- Browser (w/version): FF 75 | Chrome 80.0.3987.163
- User role (client, copilot or manager): Account Manager
- Account used: TCConAccountMgr

[maxceem]

@vikasrohit should we fix this?

[vikasrohit]

We can do this.

[maxceem]

• We should additionally allow seeing the salseforce and Direct link to the users with Project Role account_manager
• Instead of just adding another role to the existent code https://github.com/appirio-tech/connect-app/blob/dev/src/projects/detail/containers/ProjectInfoContainer.js#L428-L444 we have to rewrite this code using our new way of defining permissions.
  • Add a new permission VIEW_DIRECT_AND_SALSEFORCE_LINKS. See Permissions Guide on how to do it. Also, you may check similar issues to learn how to refactor code to use new permissions [$10] Toggle button is not working for Copilot and customer users.  #3774 or [$40] Sometimes when the user doesn't have permission to edit file/links; app shows the Remove/Edit options. #3858.
• If some props or variables are not in use anymore after this change, please, remove them as redundant code.

[lakshmiathreya]

This is fixed due to the Project Role change. All managers joining the Project are required to have an additional Connect Manager Role.

[lakshmiathreya]

The above screenshot shows Direct and Salesforce links for Account manager - handle - lakshmiaconacmg.

[lakshmiathreya]

Fixed as part of #4101