Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$10] Toggle button is not working for Copilot and customer users. #3774

Closed
drasticdpk opened this issue Mar 11, 2020 · 46 comments
Closed

[$10] Toggle button is not working for Copilot and customer users. #3774

drasticdpk opened this issue Mar 11, 2020 · 46 comments
Assignees
Labels
ACCEPTED CF Issue for Community Fixes in the current Bug Bash Functional NeedToVerifyByManagerAcc Those issue need to verify from manager or admin acc PAID QA Pass in Dev QA Pass in Prod
Milestone

Comments

@drasticdpk
Copy link
Collaborator

Expected behavior

The toggle button should function accordingly while clicking on an off.

Actual behavior

There is no difference in the project list even after clicking the My Projects toggle button.
Suggestion: If this doesn’t imply for Copilot/Customer or other roles then we don’t need to have this feature for them.

Steps to reproduce the problem

  1. Login as Copilot/customer user.
  2. Go to the dashboard.
  3. Go to Top Right header menu.
  4. Click on Toggle Button of “My Projects”

Screenshot/screencast

Attach or link a resource.
off
On

--

Environment

  • OS: Windows-10
  • Browser (w/version): Chrome/ Version 80.0.3987.122 (Official Build) (64-bit))
  • User role (client, copilot or manager): Copilot
  • Account used: topcoderconnect+copilot@gmail.com
@drasticdpk drasticdpk added this to the 2.8 milestone Mar 11, 2020
@vikasrohit
Copy link

Good catch @drasticdpk . I will add this to feature planning board so that we can get product manager's feedback.

@drasticdpk drasticdpk modified the milestones: 2.8, 2.9 Mar 12, 2020
@vikasrohit
Copy link

Got confirmation from product manager, we are good with removing the switch for customers and copilots for now. Not urgent, so we can keep it in release 2.9.

@maxceem
Copy link
Collaborator

maxceem commented Apr 15, 2020

Sum up:

@maxceem maxceem changed the title Toggle button is not working for Copilot and customer users. [$10] Toggle button is not working for Copilot and customer users. Apr 15, 2020
@maxceem maxceem added Open for Pickup CF Issue for Community Fixes in the current Bug Bash and removed cf-pipeline labels Apr 15, 2020
@iversonLv
Copy link
Contributor

@bug-bash-helper assign

@bug-bash-hunt-helper
Copy link

@iversonLv ✅ you are now assigned to this issue and have 12 hours to complete it.

As soon as you are done, please, make a comment like below, including the link to the pull request:

@bug-bash-helper <link to PR> is ready for review

@iversonLv
Copy link
Contributor

@bug-bash-helper unassign

@bug-bash-hunt-helper
Copy link

@iversonLv ✅ you have been unassigned from this issue.

Now you may pick up another issue which is open for pickup if you like to.

@ijxsid
Copy link

ijxsid commented Apr 15, 2020

@bug-bash-helper assign

@bug-bash-hunt-helper
Copy link

@ijxsid ✅ you are now assigned to this issue and have 12 hours to complete it.

As soon as you are done, please, make a comment like below, including the link to the pull request:

@bug-bash-helper <link to PR> is ready for review

@ijxsid ijxsid removed their assignment Apr 15, 2020
@rashmi73
Copy link
Contributor

@bug-bash-helper assign

@bug-bash-hunt-helper
Copy link

@rashmi73 🛑 this issue is not open for pick up.

You may only pickup issues which are included in this Bug Bash and open for pick up.
Such issues have open status and have labels CF and Open for Pickup.

@rashmi73
Copy link
Contributor

@maxceem I would like to work on it

@srjr19
Copy link
Contributor

srjr19 commented Apr 15, 2020

@bug-bash-helper assign

@bug-bash-hunt-helper
Copy link

@simranb86 🛑 this issue is not open for pick up.

You may only pickup issues which are included in this Bug Bash and open for pick up.
Such issues have open status and have labels CF and Open for Pickup.

@drasticdpk
Copy link
Collaborator Author

Prod Verified for Customer and Copilot Role.
image

@lakshmiathreya Please confirm from manager Role and close the issue.

@drasticdpk drasticdpk added the NeedToVerifyByManagerAcc Those issue need to verify from manager or admin acc label Apr 29, 2020
@lakshmiathreya
Copy link

Toggle button working as expected for Manager users:
Screenshot 2020-04-29 at 4 29 09 PM
Screenshot 2020-04-29 at 4 30 05 PM

@drasticdpk
Copy link
Collaborator Author

@maxceem , need confirmation for Copilot manger Role. Here could not see toggle button for Copilot Manager too.

users for testing:
pshah_customer - shouldn't see
pshah_copilot - shouldn't see
pshah_manager - should see

image

@drasticdpk drasticdpk reopened this Apr 29, 2020
@maxceem
Copy link
Collaborator

maxceem commented Apr 29, 2020

@drasticdpk This looks like an issue, only copilots and customers shouldn't see it. Other users should see it.

@lakshmiathreya
Copy link

@drasticdpk we will need to set this to QA Fail in Dev and Prod right?

@drasticdpk
Copy link
Collaborator Author

@lakshmiathreya QA Fail in Prod/Dev

@codejamtc
Copy link
Collaborator

Fixed in Dev: 🆗

image

@drasticdpk
Copy link
Collaborator Author

Any idea how can we verify this issue for prod env with Copilot Manger Role ? Since we don't have user credential with Copilot Manager Role ? cc @lakshmiathreya @maxceem @vikasrohit

@vikasrohit vikasrohit modified the milestones: 2.9, 2.9.1 May 6, 2020
@drasticdpk
Copy link
Collaborator Author

With reference to Dev env verification, I am closing it. Let us know if we have any way to verify on prod env.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ACCEPTED CF Issue for Community Fixes in the current Bug Bash Functional NeedToVerifyByManagerAcc Those issue need to verify from manager or admin acc PAID QA Pass in Dev QA Pass in Prod
Projects
None yet
Development

No branches or pull requests

9 participants