Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invitation Cancel if user click other than Join Project Button #3972

Closed
drasticdpk opened this issue Apr 29, 2020 · 9 comments
Closed

Invitation Cancel if user click other than Join Project Button #3972

drasticdpk opened this issue Apr 29, 2020 · 9 comments
Assignees
Labels
Dev Environment Issue reported against Dev Environment Functional Prod Environment Issue Reported in Production Environment QA Pass in Prod
Milestone

Comments

@drasticdpk
Copy link
Collaborator

Expected behavior

Invitation should be cancel only if user click on cancel button.

Actual behavior

Invitation is cancelling when user makes click other than Join Project button.

Steps to reproduce the problem

  • Invite the user to Join the Project
  • Login from the user ( which was invited )
  • Click the invitation confirmation window (other than join project button.)

Screenshot/screencast

https://monosnap.com/file/vLohqvg2P6gRdyozPToXsi1disn0MA
image

Environment

  • OS: macOS
  • Browser (w/version): Google Chrome/ FireFox
  • User role (client, copilot or manager): Client
@lakshmiathreya lakshmiathreya added the Prod Environment Issue Reported in Production Environment label Apr 29, 2020
@drasticdpk drasticdpk added this to the 2.9 milestone Apr 29, 2020
@drasticdpk
Copy link
Collaborator Author

cc @maxceem

@drasticdpk drasticdpk added the Dev Environment Issue reported against Dev Environment label Apr 29, 2020
@maxceem
Copy link
Collaborator

maxceem commented Apr 29, 2020

@vikasrohit should we fix it as a hotfix in 2.9 or include in the next 2.10 release?

@vikasrohit
Copy link

I think saw this issue before this release as well, so I guess it should be okay to have it as regular release. However, lets create hotfix branch for 2.9.1 and do these changes there and if needed we would merge it master for hotfix otherwise we would just merge it to dev.

@maxceem
Copy link
Collaborator

maxceem commented Apr 29, 2020

@vikasrohit what should happen if we click outside the dialog?

  1. Nothing
  2. Got back to the project listing page?

@vikasrohit
Copy link

Nothing. Because I would like user to explicitly click on Cancel to decline the invite.

@codejamtc
Copy link
Collaborator

@drasticdpk
Copy link
Collaborator Author

Still having same issue : Fail on prod env.
https://monosnap.com/file/7UrKDgKRKYJ8yqL4vRpQJ90Wr8Hs2F

@maxceem
Copy link
Collaborator

maxceem commented May 6, 2020

@drasticdpk issues in milestone 2.9.1 https://github.com/appirio-tech/connect-app/milestone/92 are not yet deployed to PROD.

@drasticdpk
Copy link
Collaborator Author

Verified on prod
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dev Environment Issue reported against Dev Environment Functional Prod Environment Issue Reported in Production Environment QA Pass in Prod
Projects
None yet
Development

No branches or pull requests

5 participants