Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permissions (base code) #3847

Merged
merged 20 commits into from
Apr 14, 2020
Merged

Permissions (base code) #3847

merged 20 commits into from
Apr 14, 2020

Conversation

maxceem
Copy link
Collaborator

@maxceem maxceem commented Apr 3, 2020

Base code for implementing issue #2841

looks version of lodash has changed and behaviour of "isMatch" changed, but not sure
@maxceem
Copy link
Collaborator Author

maxceem commented Apr 10, 2020

@vikasrohit this PR has been tested on TEST env via #3856 and ready to merge to DEV.

I guess it would be good if you have a quick look before merging.

@maxceem maxceem requested a review from vikasrohit April 10, 2020 13:59
@vikasrohit vikasrohit merged commit 0137f72 into dev Apr 14, 2020
Copy link

@vikasrohit vikasrohit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants