-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Permissions (base code) #3847
Merged
Merged
Permissions (base code) #3847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To be same with Project Service
# Conflicts: # src/projects/detail/containers/ProjectSummaryReportContainer.jsx
show role variable name fix command to watch and rebuild html file
looks version of lodash has changed and behaviour of "isMatch" changed, but not sure
@vikasrohit this PR has been tested on TEST env via #3856 and ready to merge to DEV. I guess it would be good if you have a quick look before merging. |
vikasrohit
reviewed
Apr 14, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Base code for implementing issue #2841
updated
checkPermission
by adopting the method which we have in Project Service in the next commit 1a2f044allowRoles
anddenyRoles
rules. See more detailed explanation and future plans here General permission methods topcoder-platform/tc-project-service#346for the proof of concept updated code for the User Profile Settings page to use a new method
added a script that generates an HTML document from the permission configuration with all the permissions.
Please, have a look at the demo document https://htmlpreview.github.io/?https://github.com/appirio-tech/connect-app/blob/feature/permissions/docs/permissions.html