Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PROD] Milestone Management - Customer Approval #4478

Merged
merged 20 commits into from
Sep 7, 2021
Merged

[PROD] Milestone Management - Customer Approval #4478

merged 20 commits into from
Sep 7, 2021

Conversation

elkhawajah
Copy link
Contributor

In this release:

  • The PM/Copilot can set specific milestones 'In Review' to ask for customer approval
  • Customer will see approval buttons in the Milestone table to approve/reject, in case of rejection, the customer needs to set a reason
  • PM/Copilot will get a feedback modal at top of the page in project page, about the result of the milestone approvals, if rejected or accepted
  • No notification via email will be communicated regarding a pending approval or completed approval in this release

tasqat and others added 20 commits August 20, 2021 16:34
@tasqat
initial customer approval fix
54103e8
@tasqat
removed the milsetone branch from being deployed
39121fc
@tasqat
Final Fixes for customer approval
ad91061 
https://software.topcoder.com/review/actions/ViewIterativeReview?rid=597391
@tasqat
styling and bug fixes
4865c90
@tasqat
add the branch to deploy
11d6982
@tasqat
fixed linting
ecc593c
@tasqat
fixed linting
3d2d0ea
@tasqat
merge fix
95c6fbc
@tasqat
Improve UX on approving milestones, it does not refresh page on succe…
875299c 
…ssful approve/reject.
@tasqat
https://github.com/appirio-tech/connect-app/issues/4474
fafe11a 
- Disable Double click for every Button.
- Update Toaster message as well As Milestone rejected successfully
- Unable to Reject Milestone >> Let’s disable done button until user does not enter any text.
@tasqat
lint fix
27059b9
@RishiRajSahu
Merge pull request #4472 from appirio-tech/hotfix/issue-4427-4460-4415
8cab597 
[HOTFIX][DEV] Fixes for issues 4427, 4460 and 4415
@RishiRajSahu
Merge pull request #4473 from appirio-tech/feature/milestone-customer…
853fb37 
…-approval

[DEV] Customer Approval
@tasqat
Fixed adding copilot bug in new milestone management
c408128
@tasqat
lint fix
a7df2c8
@RishiRajSahu
Merge pull request #4477 from appirio-tech/feature/milestone-customer…
8f9c729 
…-approval

[HOTFIX][DEV] Fixed adding copilot bug in new milestone management
@tasqat
rename phased to paused
d651aa7
@elkhawajah
Merge pull request #4479 from appirio-tech/feature/milestone-customer…
6eac5d1 
…-approval

[HOTFIX][DEV] rename phased to paused
@nursoltan-s
E2E Testing: fix failing tests, Milestone (#4482)
ad35f19 
* fix failing tests

* change test data
@nursoltan-s
hotfix: fix failing test (#4483)
21eabe9 
* hotfix: fix failing test

* fixed lint error
@RishiRajSahu RishiRajSahu merged commit 7dd6088 into master Sep 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@elkhawajah @RishiRajSahu @tasqat @nursoltan-s