Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adjustments for shared recorder framework code #1164

Merged
merged 1 commit into from
Nov 1, 2023

Conversation

eglitise
Copy link
Collaborator

@eglitise eglitise commented Nov 1, 2023

While working on recorder updates for Python, I made various changes that affect all recorder frameworks, so I decided to submit them as a separate PR.
Changes include:

  • Fix codeFor_executeScript for Java (wrong expected format for the argument variable)
  • Move codeFor_startActivity to the base class since it will be the same for all frameworks
  • Split codeFor_executeScript into handler methods with argument and without arguments. Move common method to the base class since it will be the same for all frameworks
  • Remove various base class methods that are unused or already implemented in all recorder frameworks
  • When encountering an unsupported locator strategy or method, do not raise error, but instead add a comment in the generated code
    • There is one situation where an error may still be raised - if codeFor_startActivity is requested for a non-Java framework. This will be resolved once codeFor_executeScriptWithArgs is implemented in all frameworks.

@eglitise eglitise added the fix This resolves a user-facing problem label Nov 1, 2023
@jlipps jlipps merged commit 5c31d87 into appium:main Nov 1, 2023
5 checks passed
@eglitise eglitise deleted the global-recorder-updates branch November 2, 2023 06:59
shiva-guntoju pushed a commit to shiva-guntoju/appium-inspector that referenced this pull request Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix This resolves a user-facing problem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants