Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fallback to default server tab when unselecting current provider #1396

Merged
merged 1 commit into from
Mar 19, 2024

Conversation

eglitise
Copy link
Collaborator

Small fix for the cloud provider selection modal for the following user flow:

  1. Open the cloud provider selection and enable one or more providers
  2. Close the selection and switch to any provider tab
  3. Open the cloud provider selection again and disable the currently selected provider

Currently this behavior results in the server details disappearing altogether, though it can be fixed by explicitly selecting the default server tab.
This change makes it so that the app automatically switches to the default tab in this situation.

@github-actions github-actions bot added the fix This resolves a user-facing problem label Mar 19, 2024
@eglitise eglitise merged commit e3dd8e8 into appium:main Mar 19, 2024
6 checks passed
@eglitise eglitise deleted the fallback-to-default-server-tab branch March 19, 2024 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix This resolves a user-facing problem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants