Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve presentation of saved gestures table #1623

Merged
merged 8 commits into from
Aug 22, 2024

Conversation

eglitise
Copy link
Collaborator

@eglitise eglitise commented Aug 21, 2024

This PR has a few improvements to the Saved Gestures tab:

  • Limit the table height to the Inspector window height
    • Now, if the user has many gestures, only the table contents will be scrolled, rather than the entire gestures tab
    • It is no longer necessary to scroll to the bottom of the list in order to access the add/upload buttons
    • Table header is now sticky
  • Visualise the gesture over screenshot on table row mouseover, rather than on click
    • This provides more immediate feedback, and also fixes a bug where the drawn gesture remained visible after deleting the gesture
  • Fix issue with duplicate keys in the gesture upload errors modal
  • Increase the z-index of table button tooltips (the table sticky header was hiding them)
    • This fix was also applied to the saved capability sets table buttons

@github-actions github-actions bot added the enhancement New feature or request label Aug 21, 2024
@eglitise eglitise merged commit 2d86ab0 into appium:main Aug 22, 2024
6 checks passed
@eglitise eglitise deleted the draw-gestures-on-mouseover branch August 22, 2024 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants